Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Update helpers.ts #1581

Merged
merged 8 commits into from
Oct 6, 2021
Merged

Update helpers.ts #1581

merged 8 commits into from
Oct 6, 2021

Conversation

ashachaf
Copy link
Collaborator

@ashachaf ashachaf commented Oct 3, 2021

adding support to gnisis safe and xDefi wallets
#1536
#1579

adding support to gnisis safe and xDefi wallets
#1536 
#1579
@ashachaf ashachaf requested a review from zavelevsky October 3, 2021 12:13
@github-actions
Copy link

github-actions bot commented Oct 3, 2021

Visit the preview URL for this PR (updated for commit 138f357):

https://bancor-v2-beta--pr1581-adding-wallet-suppor-ht3m4ed4.web.app

(expires Wed, 13 Oct 2021 10:40:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Collaborator

@zavelevsky zavelevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straightforward

using version 1.34.2
@ashachaf
Copy link
Collaborator Author

ashachaf commented Oct 6, 2021

@zavelevsky

  • i've added support to xdefi and gnosis
  • i've updated the version to 1.34.2 (last known stable version)
    checks:
  • there is no loading issue
  • metamask is now visible on both edge cases (fix the issue identify in version 1.35)

please review

@zavelevsky
Copy link
Collaborator

@ashachaf yarn.lock wasn't updated (it's not enough to change the version in package.json - you also need to run yarn).

@zavelevsky zavelevsky merged commit 038bb87 into master Oct 6, 2021
@zavelevsky zavelevsky deleted the adding-wallet-support branch October 6, 2021 12:30
This was referenced Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants