Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote with BNT #753

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Vote with BNT #753

merged 9 commits into from
Nov 7, 2023

Conversation

zavelevsky
Copy link
Collaborator

fixes #748

Copy link

cloudflare-workers-and-pages bot commented Nov 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 304c98f
Status: ✅  Deploy successful!
Preview URL: https://3d1f467d.falafel.pages.dev
Branch Preview URL: https://feature-vote-bnt.falafel.pages.dev

View logs

@zavelevsky zavelevsky marked this pull request as draft November 3, 2023 03:16
@ashachaf
Copy link
Collaborator

ashachaf commented Nov 5, 2023

  • notification update
    currently, when staking/unstaking BNT, the notification indicates "vBNT".
    update the text to indicate the relevant token.

  • stake 2 transaction flow
    need to verify further but it seems that when an approval is required, the flow only triggers the approve and not the stake.
    flow:

  1. stake 10 BNT
  2. approve popup shows up
  3. confirm approve
    expected: see the stake transaction on metamask
    actual: nothing happens and the user needs to trigger the stake again using the interface

@ashachaf
Copy link
Collaborator

ashachaf commented Nov 6, 2023

  • text update:
    current:
    Bancor is a DAO managed by vBNT and/or BNT stakers who determine the future of the protocol with their proposals. In order to actively participate in the DAO, stake vBNT or BNT (or both) to receive voting powers.
    updated:
    Bancor operates as a Decentralized Autonomous Organization (DAO), enabling community-driven protocol management through proposal submissions.
    Participate in Bancor's DAO by staking vBNT and/or BNT, granting you voting power and an active role in the decision-making process.

  • text update:
    current:
    In order to participate in Bancor governance activities, you should stake vBNT tokens.
    updated:
    Participate in Bancor Governance activities by staking vBNT.

  • text update:
    current:
    In order to participate in Bancor governance activities, you should stake BNT tokens.
    updated:
    Participate in Bancor Governance activities by staking BNT.

@zavelevsky zavelevsky marked this pull request as ready for review November 7, 2023 01:47
Copy link
Collaborator

@pingustar pingustar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Currently only have my phone on me, will be able to run it later today for sanity checks

@zavelevsky zavelevsky merged commit f7cbd0a into main Nov 7, 2023
5 checks passed
@zavelevsky zavelevsky deleted the feature/vote-bnt branch November 7, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vote page - add support for BNT stake/unstake
3 participants