compensate for API error by assuming all fees are network fees #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
39318d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://63256769.falafel.pages.dev |
| Branch Preview URL: | https://fix-fees-vote.falafel.pages.dev |
ashachaf
approved these changes
Oct 26, 2023
GrandSchtroumpf
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #749
A vote passed to use 100% of the fees - so there shouldn't be any LP fees.
They are derived from API total fees - network fees.
For some reason API returns wrong values - and until it's fixed we are zeroing it in the UI
summary of changes:
updated link to vote (used in all relevant tooltips)
showing total fees as network fees in stats breakdown tooltip (removed a line)
Pools table - fees always 0 in tooltip and no longer show NEW anywhere when 0
APR is always 0 unless there are rewards
Don't show NEW in available to stake in portfolio