Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: External Migration (Portal) #398

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

pingustar
Copy link
Collaborator

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 2, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: aeca98f
Status: ✅  Deploy successful!
Preview URL: https://d2073016.falafel.pages.dev

View logs

@ashachaf ashachaf changed the title Feature: Vampire Attack Feature: External Migration (Portal) Jun 2, 2022
@ashachaf
Copy link
Collaborator

ashachaf commented Jun 2, 2022

  • always show both token symbols. if we dont have the image, use a placeholder
  • list should be based on pool token value. highest should be first.
  • missing notification on confirmation
  • approve is indicating lpTKN. consider using a better name (if available). for example, ETH/DAI pool.

@pingustar pingustar marked this pull request as ready for review June 3, 2022 12:58
@pingustar pingustar requested review from zavelevsky and ashachaf June 3, 2022 12:58
zavelevsky
zavelevsky previously approved these changes Jun 5, 2022
Copy link
Collaborator

@zavelevsky zavelevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashachaf
Copy link
Collaborator

ashachaf commented Jun 6, 2022

  • we might have inaccuracy with the numbers we show

image

image

please include a disclaimer: "Amount might vary on execution" and position it below the grey box (and above the CTA)

image

- [ ] add negative "-" before the value

image

when we show the amount in red, please add - below the value. currently: $154,207 updated: -$154,207
  • when migrating ETH-non supported TKN pair
    Confirm the non supported TKN is set to the user's wallet correctly

@ashachaf
Copy link
Collaborator

ashachaf commented Jun 13, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants