Refactor triangle-mode #651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platonfloria
force-pushed
the
triangle-mode-refactor
branch
from
4ce3232 to
bd4e627
Compare
sklbancor
requested changes
May 13, 2024
sklbancor
reviewed
May 13, 2024
platonfloria
force-pushed
the
triangle-mode-refactor
branch
3 times, most recently
from
f827557 to
140b3f8
Compare
platonfloria
force-pushed
the
sei-release-candidate
branch
from
fe5aba8 to
adeece8
Compare
platonfloria
force-pushed
the
triangle-mode-refactor
branch
2 times, most recently
from
1ef62bb to
80664b2
Compare
platonfloria
force-pushed
the
sei-release-candidate
branch
from
62cd989 to
9f56e92
Compare
platonfloria
force-pushed
the
triangle-mode-refactor
branch
from
f88e811 to
89146ad
Compare
zavelevsky
force-pushed
the
sei-release-candidate
branch
from
9f56e92 to
7444e5e
Compare
barakman
changed the base branch from
triangle-rebased
to
sei-release-candidate-telos
barakman
changed the base branch from
sei-release-candidate-telos
to
sei-release-candidate
barakman
changed the base branch from
sei-release-candidate
to
sei-release-candidate-telos
platonfloria
force-pushed
the
sei-release-candidate-telos
branch
from
db253d3 to
98f6105
Compare
platonfloria
force-pushed
the
triangle-mode-refactor
branch
from
89146ad to
46559b8
Compare
platonfloria
changed the base branch from
sei-release-candidate-telos
to
sei-release-candidate
Minor Change `assert_supported` exception type from `ValueError` to `AssertionError` Remove unused return-value Remove unused code Refactor single-trianglre mode as well Remove unneeded assertion Cosmetic Fix single-triangle mode Fix single-triangle mode Refactor the b3-two-hop-triangle mode as well Remove the importing of `T` Remove unused code Remove single-triangle mode, and fix a bunch of problems Cleanup `calculate_profit` related code Fix test 042 Fix test 042 Remove unused code Some more general cleanup Cleanup Remove unused code Fix test 063 Cleanup Cleanup Fix tests Cleanup Cleanup Fix test 042 Remove single_paiwise and multi_paiwise arb modes (major change) Fix test 045 Fix test 045 Refactor the pairwise arb-mode classes Ongoing refactor Refactor triangle arb-mode classes Cleanup Remove file `scan_log_errors.py` from the repository Cleanup Remove unused code Code reuse Fix functions `create_sort_order` and `sort_key`
…tocol/fastlane-bot into refactor-encode-decode-orders
…tocol/fastlane-bot into refactor-encode-decode-orders
…tocol/fastlane-bot into refactor-encode-decode-orders
…ders Refactor the order encoding/decoding
sklbancor
reviewed
Jun 5, 2024
fastlane_bot/bot.py
Outdated
| "[bot._run] Data validation failed. Updating pools and restarting." | ||
| ) | ||
| return | ||
| arb_opp = rand_item(list_of_items=arb_opps, num_of_items=randomizer) |
There was a problem hiding this comment.
this is consistent with what we are doing now, but arguably randomisation should happen at the node level because they have the complete picture; we should just return everything we find
added 11 commits
June 5, 2024 19:44
…e opportunities found on every iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle issue #650