Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizer API #608

Closed
wants to merge 77 commits into from
Closed

Optimizer API #608

wants to merge 77 commits into from

Conversation

sklbancor
Copy link
Collaborator

@sklbancor sklbancor commented May 3, 2024

SUPERSEDED BY #628

NOTE: #610 AND #611 HAS BEEN MERGED

This branch is freezing the Optimizer API in anticipation of the move into the new repo and the more arms length relationship between the optimizer code and the bot code

The major API changes effectuated are the following

  • the CPCContainer object has been renamed to CurveContainer; whilst the old name is still legal it will be removed very soon and should be changed everywhere now
  • the signature of the alternative constructors CPC.from_xxx has slightly changed;
    • for most of them the only change was to enforce keyword rather than positional arguments for most of the arguments to avoid mistakes
    • for from_univ2 we changed the names of the liquidity arguments to liq_tknb and liq_tknq
  • the signature of the MargPOptimizer.optimize() function has changed:
    • pstart is now an argument, not part of the paramter dict (for the time being you are still allowed to supply it in the parameter dict but this will be removed soon)
    • there is a mode argument that can be MO_MODE_ABS or MO_MODE_REL that replaces params["crit"] (the latter is already illegal)
    • some of the constants and parameters have been renamed (MOXXX -> MO_XXX; also eps -> epsr and epsjac -> jach)

@sklbancor sklbancor changed the base branch from main to develop May 3, 2024 14:26
@sklbancor sklbancor force-pushed the Optimizer-API branch 8 times, most recently from 7f3946e to ba13e29 Compare May 3, 2024 21:07
@sklbancor sklbancor self-assigned this May 3, 2024
@sklbancor sklbancor force-pushed the Optimizer-API branch 6 times, most recently from c46ab27 to 6125a38 Compare May 4, 2024 08:08
@sklbancor sklbancor changed the base branch from develop to add_sei May 4, 2024 08:09
@sklbancor sklbancor force-pushed the Optimizer-API branch 2 times, most recently from d53a5e4 to 3e61276 Compare May 4, 2024 08:56
@sklbancor sklbancor changed the base branch from add_sei to convergence3 May 4, 2024 09:05
@sklbancor sklbancor force-pushed the Optimizer-API branch 3 times, most recently from 1c9e4cd to 4af7606 Compare May 4, 2024 09:26
@sklbancor sklbancor requested review from barakman and platonfloria May 4, 2024 09:32
@sklbancor sklbancor force-pushed the Optimizer-API branch 3 times, most recently from 9c2c5da to 4daddbb Compare May 4, 2024 15:27
@sklbancor sklbancor added this to the OptimizerMove milestone May 4, 2024
@sklbancor
Copy link
Collaborator Author

superseded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants