-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizer API #608
Closed
Closed
Optimizer API #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklbancor
force-pushed
the
Optimizer-API
branch
8 times, most recently
from
May 3, 2024 21:07
7f3946e
to
ba13e29
Compare
sklbancor
force-pushed
the
Optimizer-API
branch
6 times, most recently
from
May 4, 2024 08:08
c46ab27
to
6125a38
Compare
sklbancor
force-pushed
the
Optimizer-API
branch
2 times, most recently
from
May 4, 2024 08:56
d53a5e4
to
3e61276
Compare
sklbancor
force-pushed
the
Optimizer-API
branch
3 times, most recently
from
May 4, 2024 09:26
1c9e4cd
to
4af7606
Compare
sklbancor
force-pushed
the
Optimizer-API
branch
3 times, most recently
from
May 4, 2024 15:27
9c2c5da
to
4daddbb
Compare
pairwise / params
(cherry picked from commit 3a470182caddccb4bcf1daba3805e599559f453f)
platonfloria
force-pushed
the
Optimizer-API
branch
from
May 7, 2024 15:16
de434f3
to
8440505
Compare
superseded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUPERSEDED BY #628
NOTE: #610 AND #611 HAS BEEN MERGED
This branch is freezing the Optimizer API in anticipation of the move into the new repo and the more arms length relationship between the optimizer code and the bot code
The major API changes effectuated are the following
CPCContainer
object has been renamed toCurveContainer
; whilst the old name is still legal it will be removed very soon and should be changed everywhere nowCPC.from_xxx
has slightly changed;from_univ2
we changed the names of the liquidity arguments toliq_tknb
andliq_tknq
MargPOptimizer.optimize()
function has changed:pstart
is now an argument, not part of the paramter dict (for the time being you are still allowed to supply it in the parameter dict but this will be removed soon)mode
argument that can beMO_MODE_ABS
orMO_MODE_REL
that replacesparams["crit"]
(the latter is already illegal)MOXXX
->MO_XXX
; alsoeps
->epsr
andepsjac
->jach
)