Add sei #606
Add sei #606
Conversation
| @@ -113,7 +113,7 @@ class MultiCaller(ContextManager): | |||
|
|
|||
| def __init__(self, contract: web3.contract.Contract, | |||
| web3: Web3, | |||
| block_identifier: Any = 'latest', multicall_address = "0x5BA1e12693Dc8F9c48aAD8770482f4739bEeD696"): | |||
| block_identifier: Any = 'latest', multicall_address = "0xcA11bde05977b3631167028862bE2a173976CA11"): | |||
There was a problem hiding this comment.
What is this address and why was it changed?
There was a problem hiding this comment.
Let's replace with MULTICALL_CONTRACT_ADDRESS
There was a problem hiding this comment.
The MULTICALL_CONTRACT_ADDRESS constant is currently defined separately per network.
We can move it to global scope, but it will be a drop in the ocean, so no point investing too much effort into this.
| @@ -8,8 +8,8 @@ | |||
| NOTE: this class is not part of the API of the Carbon protocol, and you must expect breaking | |||
There was a problem hiding this comment.
@sklbancor do optimizer changes belong to this PR?
| @@ -205,7 +204,16 @@ | |||
| assert raises(CPC.from_carbon, yint=1, y=1, pa=1800, pb=2200, A=100, pair="ETH/USDC", tkny="ETH", fee=0, cid="1", descr="Carbon", isdydx=False) | |||
| assert raises(CPC.from_carbon, yint=1, y=1, pa=1800, pb=2200, B=100, pair="ETH/USDC", tkny="ETH", fee=0, cid="1", descr="Carbon", isdydx=False) | |||
| assert raises(CPC.from_carbon, yint=1, y=1, pa=1800, pb=2200, A=100, B=100, pair="ETH/USDC", tkny="ETH", fee=0, cid="1", descr="Carbon", isdydx=False) | |||
| assert raises(CPC.from_carbon, yint=1, y=1, pb=1800, pa=2200, pair="ETH/USDC", tkny="ETH", fee=0, cid="1", descr="Carbon", isdydx=False) | |||
| #assert raises(CPC.from_carbon, yint=1, y=1, pb=1800, pa=2200, pair="ETH/USDC", tkny="ETH", fee=0, cid="1", descr="Carbon", isdydx=False) | |||
There was a problem hiding this comment.
We should avoid committing dead code
| @@ -113,7 +113,7 @@ class MultiCaller(ContextManager): | |||
|
|
|||
| def __init__(self, contract: web3.contract.Contract, | |||
| web3: Web3, | |||
| block_identifier: Any = 'latest', multicall_address = "0x5BA1e12693Dc8F9c48aAD8770482f4739bEeD696"): | |||
| block_identifier: Any = 'latest', multicall_address = "0xcA11bde05977b3631167028862bE2a173976CA11"): | |||
There was a problem hiding this comment.
@barakman please make sure it's the right move to replace the default
There was a problem hiding this comment.
Verified (the only place where this default value is used is in test 899).
Ideally it should be removed, but since there's a default-value argument which appears before this argument, removing the default value of this argument would require removing the default value of the other argument, or replacing the order in which they are passed to the function (which would subsequently require more changes in other files).
| """ | ||
|
|
||
| NETWORK = S.NETWORK_SEI | ||
| NETWORK_ID = "1" # TODO |
| # print(strategy_typed_args) | ||
| # calculate the geometric mean | ||
| geomean_p_marg = Decimal.sqrt(pmarg0_inv * pmarg1) | ||
| self.ConfigObj.logger.debug(f"[poolandtokens.py, _carbon_to_cpc] These cids are identified as overlapping: {[x['cid'] for x in strategy_typed_args]}") |
There was a problem hiding this comment.
reconsider the verbosity
| @@ -403,10 +403,25 @@ def _carbon_to_cpc(self) -> ConstantProductCurve: | |||
| allow to omit yint (in which case it is set to y, but this does not make | |||
| a difference for the result) | |||
| """ | |||
| def calculate_parameters(y: Decimal, pa: Decimal, pb: Decimal, pm: Decimal, n: Decimal): | |||
There was a problem hiding this comment.
missing tests for this functionality - check_overlap and "cleanup" of overlapping strategies
No description provided.