Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: Add websocket usage #582

Draft
wants to merge 16 commits into
base: add_sei
Choose a base branch
from
Draft

DRAFT: Add websocket usage #582

wants to merge 16 commits into from

Conversation

platonfloria
Copy link
Collaborator

No description provided.

sklbancor
sklbancor reviewed Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@sklbancor sklbancor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor things I noticed when looking through the code.

I did not really find what I was looking for unfortunately, which is the global flow that (a) spawns the event log, and (b) calls the optimizer and thereafter the execution

fastlane_bot/events/utils.py Show resolved Hide resolved
fastlane_bot/events/listener.py Show resolved Hide resolved
fastlane_bot/events/listener.py Show resolved Hide resolved
barakman
barakman requested changes Apr 29, 2024
View reviewed changes
fastlane_bot/events/exchanges/bancor_v2.py
return event["args"]["_token2"]
return await contract.caller.reserveTokens()[1]
return event.args["_token2"]
return await contract.functions.reserveTokens()[1]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be caller, not functions.

fastlane_bot/events/listener.py Show resolved Hide resolved
fastlane_bot/events/exchanges/bancor_v2.py
return event["args"]["_token1"]
return await contract.caller.reserveTokens()[0]
return event.args["_token1"]
return await contract.functions.reserveTokens()[0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be caller, not functions.

@platonfloria platonfloria force-pushed the add-websocket-usage branch 2 times, most recently from dd930fa to 3492aeb Compare May 1, 2024 07:56
@platonfloria platonfloria changed the base branch from develop to add_sei May 1, 2024 08:41
@platonfloria platonfloria force-pushed the add-websocket-usage branch 2 times, most recently from 0b34523 to b65b9c2 Compare May 1, 2024 14:53
@platonfloria platonfloria force-pushed the add-websocket-usage branch from b65b9c2 to 1423b02 Compare May 2, 2024 07:22
@platonfloria platonfloria changed the base branch from add_sei_bp to add_sei May 3, 2024 10:00
@platonfloria platonfloria force-pushed the add-websocket-usage branch 3 times, most recently from 34d7fa7 to 4a8b537 Compare May 3, 2024 11:03
@platonfloria platonfloria force-pushed the add-websocket-usage branch from 4a8b537 to 377fecf Compare May 7, 2024 19:53
@zavelevsky zavelevsky marked this pull request as draft May 8, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklbancor sklbancor sklbancor left review comments

@barakman barakman barakman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@platonfloria @barakman @sklbancor @Lesigh-3100