Merge pull request #90 from bancorprotocol/bugfix/validator_test

fix issue in which validator test could randomly fail
bancorprotocol · Aug 28, 2023 · 2dff3f3 · 2dff3f3
2 parents 3fab529 + b333088
commit 2dff3f3
Show file tree

Hide file tree

Showing 3 changed files with 744 additions and 14 deletions.
diff --git a/fastlane_bot/bot.py b/fastlane_bot/bot.py
@@ -511,22 +511,22 @@ def validate_optimizer_trades(self, arb_opp, arb_mode, arb_finder):
         -------
         tuple or None
         """
-        (
-            best_profit,
-            best_trade_instructions_df,
-            best_trade_instructions_dic,
-            best_src_token,
-            best_trade_instructions,
-        ) = arb_opp
 
-        (
-            ordered_trade_instructions_dct,
-            tx_in_count,
-        ) = self._simple_ordering_by_src_token(
-            best_trade_instructions_dic, best_src_token
-        )
         if arb_mode == "bancor_v3" or arb_mode == "b3_two_hop":
-
+            (
+                best_profit,
+                best_trade_instructions_df,
+                best_trade_instructions_dic,
+                best_src_token,
+                best_trade_instructions,
+            ) = arb_opp
+
+            (
+                ordered_trade_instructions_dct,
+                tx_in_count,
+            ) = self._simple_ordering_by_src_token(
+                best_trade_instructions_dic, best_src_token
+            )
             cids = []
             for pool in ordered_trade_instructions_dct:
                 pool_cid = pool["cid"]