Carbon batch router #175
Open
Carbon batch router #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ivanzhelyazkov
commented
Dec 18, 2024
ivanzhelyazkov
commented
- Add CarbonBatcher contract - creates multiple strategies with one transaction
- Add tests
- Add deployment scripts
lbeder
requested changes
Dec 20, 2024
| contract CarbonBatcher is Upgradeable, Utils, ReentrancyGuard, IERC721Receiver { | ||
| using Address for address payable; | ||
|
|
||
| error InsufficientNativeTokenSent(); |
There was a problem hiding this comment.
Can this error move to common/shared utils?
|
|
||
| error InsufficientNativeTokenSent(); | ||
|
|
||
| ICarbonController private immutable carbonController; |
| error InsufficientNativeTokenSent(); | ||
|
|
||
| ICarbonController private immutable carbonController; | ||
| IVoucher private immutable voucher; |
| event FundsWithdrawn(Token indexed token, address indexed caller, address indexed target, uint256 amount); | ||
|
|
||
| constructor( | ||
| ICarbonController _carbonController, |
There was a problem hiding this comment.
We don't prefix function arguments with an _, but if you did this in order to resolve the conflict with state variables, you can call rename these arguments to initCarbonController, and initVoucher, for example
| ) validAddress(address(_carbonController)) validAddress(address(_voucher)) { | ||
| carbonController = _carbonController; | ||
| voucher = _voucher; | ||
| _disableInitializers(); |
| Token token, | ||
| address payable target, | ||
| uint256 amount | ||
| ) external validAddress(target) onlyAdmin nonReentrant { |
There was a problem hiding this comment.
Why is this function required?
| emit FundsWithdrawn({ token: token, caller: msg.sender, target: target, amount: amount }); | ||
| } | ||
|
|
||
| function onERC721Received(address, address, uint256, bytes calldata) external pure returns (bytes4) { |
| return (uniqueTokens, amounts); | ||
| } | ||
|
|
||
| function _findInArray(Token element, Token[] memory array, uint256 arrayLength) private pure returns (uint256) { |
| } | ||
| } | ||
|
|
||
| function uncheckedInc(uint256 i) private pure returns (uint256 j) { |
| } | ||
| } | ||
|
|
||
| function uncheckedInc(uint256 i) private pure returns (uint256 j) { |
There was a problem hiding this comment.
Should it moved to a common/shared utilities?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.