Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pause #138

Merged
merged 11 commits into from
Mar 11, 2024
Merged

Remove pause #138

merged 11 commits into from
Mar 11, 2024

Conversation

yudilevi
Copy link
Contributor

@yudilevi yudilevi commented Mar 5, 2024

No description provided.

Copy link
Collaborator

@ivanzhelyazkov ivanzhelyazkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Could consider removing PausableUpgradeable from the inheritance chain (might be too much of a hassle due to possibly opening up storage collisions)

deploy/scripts/mainnet/0013-CarbonController-upgrade.ts Outdated Show resolved Hide resolved
contracts/carbon/CarbonController.sol Show resolved Hide resolved
contracts/carbon/CarbonController.sol Show resolved Hide resolved
hardhat.config.ts Outdated Show resolved Hide resolved
@yudilevi yudilevi merged commit 4734655 into dev Mar 11, 2024
3 checks passed
@yudilevi yudilevi deleted the remove-pause branch March 11, 2024 12:26
0xMotto pushed a commit to Velocimeter/carbon-contracts that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants