Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POL BNT -> ETH conversion #120

Merged
merged 10 commits into from
Nov 20, 2023
Merged

POL BNT -> ETH conversion #120

merged 10 commits into from
Nov 20, 2023

Conversation

ivanzhelyazkov
Copy link
Collaborator

@ivanzhelyazkov ivanzhelyazkov commented Nov 15, 2023

Copy link
Collaborator

@lbeder lbeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should've been simpler to implement in a separate CarbonPOL-like contract, while sharing some functionality with the original CarbonPOL contract via a library. It will prevent some of the side effects and "double meaning".

Let's discuss and then I'll continue my review 🙏

contracts/pol/interfaces/ICarbonPOL.sol Outdated Show resolved Hide resolved
contracts/pol/CarbonPOL.sol Outdated Show resolved Hide resolved
contracts/pol/CarbonPOL.sol Show resolved Hide resolved
contracts/pol/CarbonPOL.sol Outdated Show resolved Hide resolved
@ivanzhelyazkov
Copy link
Collaborator Author

I think this should've been simpler to implement in a separate CarbonPOL-like contract, while sharing some functionality with the original CarbonPOL contract via a library. It will prevent some of the side effects and "double meaning".

Let's discuss and then I'll continue my review 🙏

I think that for the time being this should be sufficient - I realize there are some inconsistencies, this is why I wanted to split the logic in buy and sell - different prices, trade start times and trade functions.
But given that a new integration would be required and the technical time for that, and that we're only adding ETH->BNT trades, it's easier to keep the current interface with no changes (much simpler to integrate) .

@ivanzhelyazkov ivanzhelyazkov changed the title POL ETH -> BNT conversion POL BNT -> ETH conversion Nov 17, 2023
Copy link
Contributor

@yudilevi yudilevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, definitely much better :)

contracts/pol/CarbonPOL.sol Show resolved Hide resolved
contracts/pol/CarbonPOL.sol Outdated Show resolved Hide resolved
@ivanzhelyazkov ivanzhelyazkov merged commit 06d50bb into dev Nov 20, 2023
3 checks passed
@ivanzhelyazkov ivanzhelyazkov deleted the pol-eth-to-bnt branch November 20, 2023 14:06
0xMotto pushed a commit to Velocimeter/carbon-contracts that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants