-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POL BNT -> ETH conversion #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should've been simpler to implement in a separate CarbonPOL-like contract, while sharing some functionality with the original CarbonPOL contract via a library. It will prevent some of the side effects and "double meaning".
Let's discuss and then I'll continue my review 🙏
I think that for the time being this should be sufficient - I realize there are some inconsistencies, this is why I wanted to split the logic in buy and sell - different prices, trade start times and trade functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, definitely much better :)
POL BNT -> ETH conversion
Based on this Protocol Owned ETH Spending Proposition