Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E2E] use addresses instead of symbol for token selection #990

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[E2E] use addresses instead of symbol for token selection #990

merged 1 commit into from
Jan 16, 2024
+37 −18

Conversation

GrandSchtroumpf
Copy link
Collaborator

@GrandSchtroumpf GrandSchtroumpf commented Jan 16, 2024 •
edited
Loading

  • Use addresses instead of symbol for token selection. We currently limit the tokens to the list in debug. This can be extended later.
  • Verify if notification button is visible and not the notification itself

@GrandSchtroumpf GrandSchtroumpf requested review from pingustar and zavelevsky and removed request for pingustar January 16, 2024 14:15
zavelevsky
zavelevsky approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@zavelevsky zavelevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GrandSchtroumpf GrandSchtroumpf merged commit 933970e into main Jan 16, 2024
12 checks passed
@GrandSchtroumpf GrandSchtroumpf deleted the e2e/use-addresses branch January 16, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zavelevsky zavelevsky zavelevsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrandSchtroumpf @zavelevsky