Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to react-router #900

Merged
merged 20 commits into from
Nov 9, 2023
Merged

Update to react-router #900

merged 20 commits into from
Nov 9, 2023

Conversation

GrandSchtroumpf
Copy link
Collaborator

@GrandSchtroumpf GrandSchtroumpf commented Nov 1, 2023 •
edited
Loading

  • Install @tanstack/react-router
  • Update the routes
  • use useParams instead of useMatch
  • replace useLocation with useRouterState
  • fix type
  • Install @tanstack/react-location

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 1, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fe7db0a
Status: ✅  Deploy successful!
Preview URL: https://f78844d8.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--899.carbon-app-csq.pages.dev

View logs

@GrandSchtroumpf GrandSchtroumpf marked this pull request as ready for review November 3, 2023 08:44
zavelevsky
zavelevsky requested changes Nov 3, 2023
View reviewed changes
src/App.tsx Outdated Show resolved Hide resolved
src/components/core/MainContent.tsx Outdated Show resolved Hide resolved
src/pages/debug/index.tsx Outdated Show resolved Hide resolved
src/pages/explorer/index.tsx Outdated Show resolved Hide resolved
src/pages/explorer/index.tsx Outdated Show resolved Hide resolved
src/pages/explorer/type/index.tsx Outdated Show resolved Hide resolved
src/pages/explorer/type/overview/index.tsx Outdated Show resolved Hide resolved
zavelevsky
zavelevsky approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@zavelevsky zavelevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM - didn't test the app for broken deep links etc. Trusting that you did

@GrandSchtroumpf GrandSchtroumpf merged commit 2e666cc into main Nov 9, 2023
1 check passed
@GrandSchtroumpf GrandSchtroumpf deleted the issue-#899 branch November 9, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zavelevsky zavelevsky zavelevsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrandSchtroumpf @zavelevsky