Upgrade to React 19 #1596
Merged
Upgrade to React 19 #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrandSchtroumpf
force-pushed
the
react-19
branch
from
6c5ae51 to
626e932
Compare
Deploying carbon-app-blast with
|
| Latest commit: |
a1bfb7a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4985f288.carbon-app-blast.pages.dev |
| Branch Preview URL: | https://react-19.carbon-app-blast.pages.dev |
Deploying carbon-app-sei with
|
| Latest commit: |
a1bfb7a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ec4cf148.carbon-app-sei.pages.dev |
| Branch Preview URL: | https://react-19.carbon-app-sei.pages.dev |
Deploying carbon-app-celo with
|
| Latest commit: |
a1bfb7a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34bc1ab8.carbon-app-celo.pages.dev |
| Branch Preview URL: | https://react-19.carbon-app-celo.pages.dev |
Deploying carbon-app with
|
| Latest commit: |
a1bfb7a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://83bc17b0.carbon-app-csq.pages.dev |
| Branch Preview URL: | https://react-19.carbon-app-csq.pages.dev |
tiagofilipenunes
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Very good work, app looking snappier and snappier, approved 👍
Can you please check the points below (non-blockers):
- Could you add a script in package.json to run the vite bundle analyzer?
- I would prefer to remove the compiler packages for now if possible, and instead create an issue explaining how to enable it and handle the compiler in a separate PR instead of having commented out code
- Since you also updated framer-motion, please check that this issue is now fixed Look into framer-motion latest version bug #139.
Nice lazy loading highcharts, removing a lot of lodash uses. The waitFor in the e2e tests might improve their flakiness, nice catch too. Nice to see we can finally use Intl.Segmenter instead of Graphemer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #139
fix #1175