Trade Count

[GrandSchtroumpf]

fix #1336

• Add Trade count on strategy card
• Remove everything related to roi

What to test :

• Go to explorer page with pair ETH/USDC
• Strategies should have a trade count
• Click Filter/Sort
• Default sort should be trade, which sort by descending order

[cloudflare-workers-and-pages]

Deploying carbon-app-blast with    Cloudflare Pages

Latest commit:	7e2655a
Status:	✅  Deploy successful!
Preview URL:	https://4e34be5d.carbon-app-blast.pages.dev
Branch Preview URL:	https://issue--1336.carbon-app-blast.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying carbon-app-celo with    Cloudflare Pages

Latest commit:	7e2655a
Status:	✅  Deploy successful!
Preview URL:	https://530402e5.carbon-app-celo.pages.dev
Branch Preview URL:	https://issue--1336.carbon-app-celo.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying carbon-app with    Cloudflare Pages

Latest commit:	7e2655a
Status:	✅  Deploy successful!
Preview URL:	https://256ff570.carbon-app-csq.pages.dev
Branch Preview URL:	https://issue--1336.carbon-app-csq.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying carbon-app-sei with    Cloudflare Pages

Latest commit:	7e2655a
Status:	✅  Deploy successful!
Preview URL:	https://13ee1a0a.carbon-app-sei.pages.dev
Branch Preview URL:	https://issue--1336.carbon-app-sei.pages.dev

View logs

[tiagofilipenunes]

Looks good to me - just a minor comment about migrating the localstorage instead of keeping the roi sort enums

Also it might be best to mock the trade count route on e2e to prevent issues with screenshots

[ashachaf]

• update "trades" title
  current: "Trades"
  updated: "Trade Count" and remove the i icon and tool tip

• remove "total budget" tool tip and i icon

• update "buy {token}" tool tip
  current: This is the available amount of {quoteToken} tokens that you are willing to use in order to buy {baseToken}.
  updated: {quoteToken} tokens available to buy {baseToken}.

• update "sell {token}" tool tip
  current: This is the available amount of {baseToken} tokens that you are willing to sell.
  updated: {baseToken} tokens available for sale.