Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulator recurring handling default values #1523

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Conversation

tiagofilipenunes
Copy link
Collaborator

@tiagofilipenunes tiagofilipenunes commented Oct 1, 2024

  • Stop returning when market price does not exist
  • If market price does not exist, set min and max to 0

fix #1522

tiagofilipenunes and others added 2 commits October 1, 2024 17:57
- Stop returning when market price does not exist
- If market price does not exist, set min and max to 0
Copy link

cloudflare-workers-and-pages bot commented Oct 1, 2024

Deploying carbon-app-blast with  Cloudflare Pages  Cloudflare Pages

Latest commit: 014cc4f
Status: ✅  Deploy successful!
Preview URL: https://892301fa.carbon-app-blast.pages.dev
Branch Preview URL: https://issue--1552.carbon-app-blast.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Oct 1, 2024

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: 014cc4f
Status: ✅  Deploy successful!
Preview URL: https://e81fc24b.carbon-app-sei.pages.dev
Branch Preview URL: https://issue--1552.carbon-app-sei.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Oct 1, 2024

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 014cc4f
Status: ✅  Deploy successful!
Preview URL: https://38357b79.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--1552.carbon-app-csq.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Oct 1, 2024

Deploying carbon-app-celo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 014cc4f
Status: ✅  Deploy successful!
Preview URL: https://ed4d0700.carbon-app-celo.pages.dev
Branch Preview URL: https://issue--1552.carbon-app-celo.pages.dev

View logs

@tiagofilipenunes tiagofilipenunes changed the title Fix handling default values Fix simulator recurring handling default values Oct 1, 2024
@tiagofilipenunes tiagofilipenunes merged commit 72f6b82 into main Oct 2, 2024
4 checks passed
@tiagofilipenunes tiagofilipenunes deleted the issue-#1552 branch October 2, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Simulator] Bug when changing token selection with a token that has no market price in simulator recurring
2 participants