Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search params #1498

Merged
merged 9 commits into from
Sep 30, 2024
Merged

Improve search params #1498

merged 9 commits into from
Sep 30, 2024

Conversation

GrandSchtroumpf
Copy link
Collaborator

fix #1475

@GrandSchtroumpf GrandSchtroumpf marked this pull request as draft September 19, 2024 07:50
Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2024

Deploying carbon-app-blast with  Cloudflare Pages  Cloudflare Pages

Latest commit: c288689
Status: ✅  Deploy successful!
Preview URL: https://72487603.carbon-app-blast.pages.dev
Branch Preview URL: https://issue--1475.carbon-app-blast.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2024

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: c288689
Status: ✅  Deploy successful!
Preview URL: https://089ec7be.carbon-app-sei.pages.dev
Branch Preview URL: https://issue--1475.carbon-app-sei.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2024

Deploying carbon-app-celo with  Cloudflare Pages  Cloudflare Pages

Latest commit: c288689
Status: ✅  Deploy successful!
Preview URL: https://8e3b0fb5.carbon-app-celo.pages.dev
Branch Preview URL: https://issue--1475.carbon-app-celo.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2024

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: c288689
Status: ✅  Deploy successful!
Preview URL: https://d9e2dd85.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--1475.carbon-app-csq.pages.dev

View logs

@GrandSchtroumpf GrandSchtroumpf marked this pull request as ready for review September 20, 2024 08:29
Copy link
Collaborator

@tiagofilipenunes tiagofilipenunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, great improvement with a better integration between Tanstack Router and valibot. Just some minor suggestions. Tested the app thoroughly and no issues found.

src/components/activity/ActivityProvider.tsx Show resolved Hide resolved
src/pages/explorer/type/activity/index.tsx Outdated Show resolved Hide resolved
src/libs/routing/utils.ts Show resolved Hide resolved
@GrandSchtroumpf GrandSchtroumpf merged commit 5b26f70 into main Sep 30, 2024
4 checks passed
@GrandSchtroumpf GrandSchtroumpf deleted the issue-#1475 branch September 30, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore better way to parse search params
2 participants