Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add check that PR head commit does not start with [CI] #1474

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

tiagofilipenunes
Copy link
Collaborator

@tiagofilipenunes tiagofilipenunes commented Sep 9, 2024

If PR head commit starts with [CI], do not commit screenshots from the e2e tests

Copy link

cloudflare-workers-and-pages bot commented Sep 9, 2024

Deploying carbon-app-blast with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6401e69
Status:⚡️  Build in progress...

View logs

Copy link

cloudflare-workers-and-pages bot commented Sep 9, 2024

Deploying carbon-app-celo with  Cloudflare Pages  Cloudflare Pages

Latest commit: b117807
Status: ✅  Deploy successful!
Preview URL: https://91c4a8f6.carbon-app-celo.pages.dev
Branch Preview URL: https://fix-e2e-screenshot-commit.carbon-app-celo.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Sep 9, 2024

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: b117807
Status: ✅  Deploy successful!
Preview URL: https://ca75c920.carbon-app-csq.pages.dev
Branch Preview URL: https://fix-e2e-screenshot-commit.carbon-app-csq.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Sep 9, 2024

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: b117807
Status: ✅  Deploy successful!
Preview URL: https://83bb4cee.carbon-app-sei.pages.dev
Branch Preview URL: https://fix-e2e-screenshot-commit.carbon-app-sei.pages.dev

View logs

@tiagofilipenunes tiagofilipenunes force-pushed the fix-e2e-screenshot-commit branch from 6d93b36 to 4ff563f Compare September 9, 2024 15:56
Copy link
Collaborator

@GrandSchtroumpf GrandSchtroumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have something like ['[CI]', ...]includes(...), but I'm not sure if it's possible.

@tiagofilipenunes tiagofilipenunes merged commit 9b46524 into main Sep 11, 2024
3 of 5 checks passed
@tiagofilipenunes tiagofilipenunes deleted the fix-e2e-screenshot-commit branch September 11, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants