Hide ROI by default #1468
Merged
Hide ROI by default #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create optional config param - If param is false or undefined, hide StrategyBlockRoi and adjust StrategyBlockBudget to the full column width - Update readme with new flag
Deploying carbon-app-sei with
|
| Latest commit: |
f3ee971
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://27a8a192.carbon-app-sei.pages.dev |
| Branch Preview URL: | https://issue--1467.carbon-app-sei.pages.dev |
Deploying carbon-app with
|
| Latest commit: |
f3ee971
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dcfc59e6.carbon-app-csq.pages.dev |
| Branch Preview URL: | https://issue--1467.carbon-app-csq.pages.dev |
Deploying carbon-app-celo with
|
| Latest commit: |
f3ee971
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9b26665e.carbon-app-celo.pages.dev |
| Branch Preview URL: | https://issue--1467.carbon-app-celo.pages.dev |
Deploying carbon-app-blast with
|
| Latest commit: |
f3ee971
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5e95e91a.carbon-app-blast.pages.dev |
| Branch Preview URL: | https://issue--1467.carbon-app-blast.pages.dev |
|
|
…is undefined or is an ROI sort
ashachaf
approved these changes
Sep 5, 2024
GrandSchtroumpf
approved these changes
Sep 5, 2024
- Add comment explaining roi flag - Set strategySort after definition and change getSortAndFilterItems to filter out empty string titles
GrandSchtroumpf
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: ROI block is hidden by default
fix #1467