[Trade] History Chart #1456
Merged
[Trade] History Chart #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying carbon-app with
|
| Latest commit: |
a5c3995
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2150c22b.carbon-app-csq.pages.dev |
| Branch Preview URL: | https://issue--1454.carbon-app-csq.pages.dev |
Deploying carbon-app-sei with
|
| Latest commit: |
a5c3995
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://960fb8a8.carbon-app-sei.pages.dev |
| Branch Preview URL: | https://issue--1454.carbon-app-sei.pages.dev |
Deploying carbon-app-celo with
|
| Latest commit: |
a5c3995
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7dd97578.carbon-app-celo.pages.dev |
| Branch Preview URL: | https://issue--1454.carbon-app-celo.pages.dev |
Deploying carbon-app-blast with
|
| Latest commit: |
a5c3995
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d1cd5da9.carbon-app-blast.pages.dev |
| Branch Preview URL: | https://issue--1454.carbon-app-blast.pages.dev |
tiagofilipenunes
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Amazing improvement to the app!
Review Part 1
Create strategy:
- Can src/components/simulator/input/d3Chart/recurring/D3ChartDisposable.tsx move to src/components/simulator/input/d3Chart/disposable/D3ChartDisposable.tsx
- Limit/Range and Recurring: Chart handle allows to set negative numbers
- Limit/Range: In range option, moving the range up or down and clicking "Use Market" so that the range becomes inverted doesn't invert the numbers in the form
Screen.Recording.2024-09-11.at.16.33.11.mov
- Concentrated: Max spread/fee tier is not adjusting when moving the ranges
Screen.Recording.2024-09-11.at.16.30.28.mov
- Consider moving the chart functionality away from the components/simulator folder as it is now used elsewhere in the app
tiagofilipenunes
requested changes
Sep 11, 2024
src/components/simulator/input/d3Chart/disposable/D3ChartDisposable.tsx
Outdated
Show resolved
Hide resolved
tiagofilipenunes
previously requested changes
Sep 12, 2024
GrandSchtroumpf
dismissed
tiagofilipenunes’s stale review
approved by Costa
Costa769
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1187
fix #1453
fix #1452