Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Disposable] Reset budget on direction change #1361

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Conversation

GrandSchtroumpf
Copy link
Collaborator

fix #1359

Reset budget when changing direction change

Test case :

  • Start disposable strategy
  • Add budget
  • Change from buy order to sell order <- budget should be reset
  • Validate
  • Edit price on the same strategy
  • Add budget
  • Change from sell order to buy order <- budget should be reset

Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2024

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: 20dc4d6
Status: ✅  Deploy successful!
Preview URL: https://5dcb0d6a.carbon-app-sei.pages.dev
Branch Preview URL: https://issue--1359.carbon-app-sei.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2024

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 20dc4d6
Status: ✅  Deploy successful!
Preview URL: https://5481020c.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--1359.carbon-app-csq.pages.dev

View logs

Copy link
Collaborator

@tiagofilipenunes tiagofilipenunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ran the e2e tests again to check if they pass

@GrandSchtroumpf GrandSchtroumpf merged commit 8fdf78c into main Jul 17, 2024
2 checks passed
@GrandSchtroumpf GrandSchtroumpf deleted the issue-#1359 branch July 17, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input budget field on edit prices page
3 participants