Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Strategy Card] Truncate number to 6 decimal if range < 1 #1360

Merged
merged 14 commits into from
Jul 22, 2024

Conversation

GrandSchtroumpf
Copy link
Collaborator

@GrandSchtroumpf GrandSchtroumpf commented Jul 16, 2024

fix #1273

When order range delta is < 1 we truncate number after 6 decimals.

Test cases :

  • Create a disposable range strategy with theses prices
  • Hover graph in strategy card to see prices (price is after sdk approximation)

Both below 0:

  • Form: min 0.000000001 & max 0.01
  • Card: min 0.0₈99999 & max 0.009999

Above & below 0:

  • Form: min 0.99999 & max 1.00001
  • Card: min 0.999989 & max 1.000009

Both above 0:

  • Form: min 10.0005 & max 11.0000001
  • Card: min 10.000499 & max 11.00

Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2024

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: 762a08f
Status: ✅  Deploy successful!
Preview URL: https://e10fd038.carbon-app-sei.pages.dev
Branch Preview URL: https://issue--1273.carbon-app-sei.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2024

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 762a08f
Status: ✅  Deploy successful!
Preview URL: https://30446559.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--1273.carbon-app-csq.pages.dev

View logs

@GrandSchtroumpf GrandSchtroumpf merged commit 8600893 into main Jul 22, 2024
2 checks passed
@GrandSchtroumpf GrandSchtroumpf deleted the issue-#1273 branch July 22, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strategy overview - increase decimals for the strategy grid and market price indicator
4 participants