[Overlapping] Enable undercut

[GrandSchtroumpf]

fix #1325

Enable undercut for overlapping strategy
Reduce spread by 0.1%.

Test cases :

1. Create an overlapping strategy with spread of 1%
2. Menu -> Duplicate -> Undercut
3. Spread is now 0.99%

This work if strategy :

• has no budget nor market price
• is above/below market price
• are built out of a recurring strategy (default to 0.05*0.99)

[cloudflare-workers-and-pages]

Deploying carbon-app-sei with    Cloudflare Pages

Latest commit:	ed99aba
Status:	✅  Deploy successful!
Preview URL:	https://1a145ed6.carbon-app-sei.pages.dev
Branch Preview URL:	https://issue--1325.carbon-app-sei.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying carbon-app with    Cloudflare Pages

Latest commit:	ed99aba
Status:	✅  Deploy successful!
Preview URL:	https://aebeef6a.carbon-app-csq.pages.dev
Branch Preview URL:	https://issue--1325.carbon-app-csq.pages.dev

View logs

[tiagofilipenunes]

LGTM

Only thing to note is if the overlapping strategy has a defined budget, this budget (and anchor) won't be populated when undercutting, which is the same behaviour as overlapping duplicate but different from recurring/disposable undercut/duplicate.

[ashachaf]

• remove duplicate option from strategies with no prices
  IF order0.buyLow AND order0.sellHigh AND order1.buyLow AND order1.sellHigh = 0, remove the duplicate option from the menu

• duplicating recurring strategy opens concentrated creation
  https://github.com/user-attachments/assets/23310a69-ceaa-4f04-93a7-ee9b8e1db32e
  https://github.com/user-attachments/assets/2b4734b4-4d54-4d78-b973-0ed2c841e2fd

[tiagofilipenunes]

LGTM just one change request for the e2e test

1. Currently, the create/duplicate/undercut tests all override the create/form.png screenshot. Can you change the submit method of CreateStrategyDriver to something like this

  async submit(type: StrategyCase) {
    const btn = this.page.getByText('Create Strategy');
    if (shouldTakeScreenshot) {
      const mainMenu = new MainMenuDriver(this.page);
      await mainMenu.hide();
      await waitTooltipsClose(this.page);
      const form = this.getForm();
      const path = screenshotPath(this.testCase, type, 'form');
      await screenshot(form, path);
      await mainMenu.show();
    }
    try {
      await waitFor(this.page, 'approve-warnings', 2_000);
      if (await this.page.isVisible('[data-testid=approve-warnings]')) {
        await this.page.getByTestId('approve-warnings').click();
      }
      await btn.click();
    } catch {
      await btn.click({ timeout: 1_000 });
    }
  }

and then set they type to the strategy type.