Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trade token selection onEnter #1356

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Conversation

tiagofilipenunes
Copy link
Collaborator

Check that search selection is valid when pressing 'enter' on trade token selection modal.

Solved similarly to how 'Enter' is handled in libs/modals/modals/ModalTokenList/ModalTokenList.tsx by checking the length of the trade pair search.

fix #1355

Copy link

cloudflare-workers-and-pages bot commented Jul 15, 2024

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: d28e5d0
Status: ✅  Deploy successful!
Preview URL: https://e2353ee1.carbon-app-sei.pages.dev
Branch Preview URL: https://fix-trade-token-selection.carbon-app-sei.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jul 15, 2024

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: d28e5d0
Status: ✅  Deploy successful!
Preview URL: https://c2109671.carbon-app-csq.pages.dev
Branch Preview URL: https://fix-trade-token-selection.carbon-app-csq.pages.dev

View logs

@tiagofilipenunes tiagofilipenunes merged commit cf0763d into main Jul 16, 2024
6 of 7 checks passed
@tiagofilipenunes tiagofilipenunes deleted the fix/trade-token-selection branch July 16, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRADE] Pressing 'Enter' on token select modal with invalid search triggers onTradePairSelect error
2 participants