-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
last used pair across all pages #1348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying carbon-app-sei with Cloudflare Pages
|
ashachaf
approved these changes
Jul 14, 2024
|
zavelevsky
force-pushed
the
feature/default-pair-1331
branch
from
July 16, 2024 10:53
28f63ef
to
a16c1f3
Compare
zavelevsky
force-pushed
the
feature/default-pair-1331
branch
from
July 16, 2024 16:07
2ebef99
to
8716737
Compare
tiagofilipenunes
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two suggested changes for when the pair doesn't exist in the simulate and explore tab. The addresses may be present in the search but they can be invalid, in which case let's not set the tradePair
ashachaf
approved these changes
Jul 16, 2024
ashachaf
approved these changes
Jul 16, 2024
tiagofilipenunes
approved these changes
Jul 16, 2024
zavelevsky
force-pushed
the
feature/default-pair-1331
branch
from
July 17, 2024 08:19
088d71e
to
68b7768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1331
When visiting the following pages: trade, explore (by pair), simulate, create strategy - the selected pair becomes the default pair.
Note - the current behavior is buggy.
If you start to create a strategy and select a pair that doesn't exist yet it becomes the default pair, even if you don't complete the strategy creation - ending up with a bad "empty" experience in other pages.
It can also be more problematic with imported tokens etc.
I personally think that strategy creation shouldn't dictate the pair - or it should only take place once the strategy was created - or only if the pair already exists.