Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onclick close notification to "view activity" link #1272

Merged
merged 9 commits into from
Jun 27, 2024

Conversation

tiagofilipenunes
Copy link
Collaborator

fix #1206

Copy link

cloudflare-workers-and-pages bot commented Jun 17, 2024

Deploying carbon-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 55dc730
Status: ✅  Deploy successful!
Preview URL: https://00e849cc.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--1206.carbon-app-csq.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jun 17, 2024

Deploying carbon-app-sei with  Cloudflare Pages  Cloudflare Pages

Latest commit: 55dc730
Status: ✅  Deploy successful!
Preview URL: https://f4280aa4.carbon-app-sei.pages.dev
Branch Preview URL: https://issue--1206.carbon-app-sei.pages.dev

View logs

@ashachaf
Copy link
Collaborator

ashachaf commented Jun 17, 2024

  • incorrect flow behavior
    actual:
    on click:
  • user is redirected to the relevant activity page
  • activity notification is removed (as if the user clicked the x to delete it)

expected:
on click:

  • user is redirected to the relevant activity page
  • activity notification to stay visible in the notification menu
  • notification menu to close and show the relevant activity page (which was opened on step 1)

@tiagofilipenunes tiagofilipenunes marked this pull request as draft June 18, 2024 18:58
@tiagofilipenunes tiagofilipenunes marked this pull request as ready for review June 20, 2024 10:45
@ashachaf
Copy link
Collaborator

ashachaf commented Jun 25, 2024

  • menu flow update
    flow:
  • click the bell icon
  • click "view activity" on one of the existing notifications
    actual:
  • redirect to the page AND menu stays open. this result in not knowing that the redirect happened.
    expected:
  • redirect to the page AND CLOSE the menu.

@tiagofilipenunes tiagofilipenunes merged commit 66e4248 into main Jun 27, 2024
5 of 6 checks passed
@tiagofilipenunes tiagofilipenunes deleted the issue-#1206 branch June 27, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Activity] Notifications - on click close the notification menu
3 participants