Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: meta-balena-esr: fix array creation #3587

Closed
wants to merge 1 commit into from
Closed

Conversation

alexgg
Copy link
Contributor

@alexgg alexgg commented Jan 1, 2025

By removing linter errors and adding quotes inside the array, its contents become a single element string which is not the intention, as it should become a semver array.

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

By removing linter errors and adding quotes inside the array, its
contents become a single element string which is not the intention, as
it should become a semver array.

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
@alexgg alexgg requested a review from rcooke-warwick January 1, 2025 18:53
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg had a problem deploying to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Failure
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-staging.com January 1, 2025 18:53 — with GitHub Actions Inactive
@alexgg alexgg requested a review from klutchell January 1, 2025 18:55
Copy link
Contributor

flowzone-app bot commented Jan 1, 2025

Website deployed to CF Pages, 👀 preview link https://a23f8975.balena-os.pages.dev

@klutchell
Copy link
Collaborator

Seems to be a duplicate of #3542

@alexgg alexgg temporarily deployed to balena-cloud.com January 1, 2025 20:22 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com January 1, 2025 20:22 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com January 1, 2025 20:22 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com January 1, 2025 20:26 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com January 1, 2025 20:26 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com January 1, 2025 20:26 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com January 1, 2025 20:29 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com January 1, 2025 20:29 — with GitHub Actions Inactive
@alexgg alexgg temporarily deployed to balena-cloud.com January 1, 2025 20:29 — with GitHub Actions Inactive
@klutchell
Copy link
Collaborator

Closing as a duplicate of #3542

@klutchell klutchell closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants