Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modemmanager: Fix Quectel modems initialization bug #3478

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

floion
Copy link
Contributor

@floion floion commented Jul 24, 2024

With the update to ModemManager version 1.22.0 we now have some Quectel modems failing to use QMI properly:

ModemManager[1178]: [modem0] power state updated: on ModemManager[1178]: [modem0] (quectel) modem reset detected, triggering reprobe ModemManager[1178]: [modem0] (quectel) modem reset detected, triggering reprobe .
.
.
ModemManager[1178]: [modem0] failed waiting for final state: Too much time waiting to get to a final state ModemManager[1178]: [modem0] failed enabling modem: Operation was cancelled ModemManager[1178]: [modem1] couldn't start initialization: Transaction timed out ModemManager[1178]: [modem1] fatal error initializing: Fatal error: modem is unusable

This has been fixed upstream with the 2 patches we backport here:

ModemManager[1139]: [modem0] power state updated: on
ModemManager[1139]: [modem0] (quectel) continuing without enabling profile manager events


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@floion floion force-pushed the fix_quectel_modems branch from 0599e2a to 8b81baa Compare July 24, 2024 09:05
@floion floion temporarily deployed to balena-cloud.com July 24, 2024 09:06 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 24, 2024 09:06 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 24, 2024 09:06 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 24, 2024 09:06 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 24, 2024 09:06 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 24, 2024 09:06 — with GitHub Actions Inactive
Copy link

github-actions bot commented Jul 24, 2024

Website deployed to CF Pages, 👀 preview link https://ec76a2ba.balena-os.pages.dev

@floion floion temporarily deployed to balena-cloud.com July 24, 2024 09:36 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 24, 2024 09:36 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 24, 2024 09:36 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 24, 2024 09:38 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 24, 2024 09:38 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 24, 2024 09:38 — with GitHub Actions Inactive
With the update to ModemManager version 1.22.0 we now have some Quectel modems failing
to use QMI properly:

ModemManager[1178]: [modem0] power state updated: on
ModemManager[1178]: [modem0] (quectel) modem reset detected, triggering reprobe
ModemManager[1178]: [modem0] (quectel) modem reset detected, triggering reprobe
.
.
.
ModemManager[1178]: [modem0] failed waiting for final state: Too much time waiting to get to a final state
ModemManager[1178]: [modem0] failed enabling modem: Operation was cancelled
ModemManager[1178]: [modem1] couldn't start initialization: Transaction timed out
ModemManager[1178]: [modem1] fatal error initializing: Fatal error: modem is unusable

This has been fixed upstream with the 2 patches we backport here:

ModemManager[1139]: [modem0] power state updated: on
ModemManager[1139]: [modem0] (quectel) continuing without enabling profile manager events

Change-type: patch
Signed-off-by: Florin Sarbu <[email protected]>
@floion floion force-pushed the fix_quectel_modems branch from 8b81baa to 2d53d2c Compare July 29, 2024 14:45
@floion floion temporarily deployed to balena-cloud.com July 29, 2024 14:45 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 29, 2024 14:45 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 29, 2024 14:45 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 29, 2024 14:45 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 29, 2024 14:45 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 29, 2024 14:45 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 29, 2024 15:46 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 29, 2024 15:46 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 29, 2024 15:46 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 29, 2024 16:07 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 29, 2024 16:07 — with GitHub Actions Inactive
@floion floion temporarily deployed to balena-cloud.com July 29, 2024 16:07 — with GitHub Actions Inactive
@floion
Copy link
Contributor Author

floion commented Jul 30, 2024

@resin-jenkins test this please

5 similar comments
@floion
Copy link
Contributor Author

floion commented Jul 31, 2024

@resin-jenkins test this please

@floion
Copy link
Contributor Author

floion commented Jul 31, 2024

@resin-jenkins test this please

@floion
Copy link
Contributor Author

floion commented Aug 1, 2024

@resin-jenkins test this please

@floion
Copy link
Contributor Author

floion commented Aug 1, 2024

@resin-jenkins test this please

@floion
Copy link
Contributor Author

floion commented Aug 1, 2024

@resin-jenkins test this please

@alexgg
Copy link
Contributor

alexgg commented Aug 6, 2024

@resin-jenkins retest this please

@floion
Copy link
Contributor Author

floion commented Aug 7, 2024

@resin-jenkins test this please

3 similar comments
@floion
Copy link
Contributor Author

floion commented Aug 8, 2024

@resin-jenkins test this please

@floion
Copy link
Contributor Author

floion commented Aug 9, 2024

@resin-jenkins test this please

@floion
Copy link
Contributor Author

floion commented Aug 9, 2024

@resin-jenkins test this please

@floion floion merged commit 91262b4 into master Aug 9, 2024
79 checks passed
@floion floion deleted the fix_quectel_modems branch August 9, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants