Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix possible race condition in (*os.Cmd).Wait() #52

Closed
wants to merge 1 commit into from
Closed

fix possible race condition in (*os.Cmd).Wait() #52

wants to merge 1 commit into from

Conversation

wrboyce
Copy link
Contributor

@wrboyce wrboyce commented Apr 24, 2019

Connects-to: #33
Change-type: patch
Signed-off-by: Will Boyce <[email protected]>

@wrboyce wrboyce requested review from hedss and Page- as code owners April 24, 2019 17:22
Page-
Page- previously approved these changes Apr 25, 2019
View reviewed changes
hedss
hedss reviewed Apr 29, 2019
View reviewed changes
Copy link

@hedss hedss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked through, and it all sounds sensible, but in honesty I don't know enough go to feel I can officially 'approve'.

@wrboyce
fix possible race condition in (*os.Cmd).Wait()
11da2b2 
Connects-to: #33
Change-type: patch
Signed-off-by: Will Boyce <[email protected]>
@kaisoz kaisoz added the versionbot/pr-draft Draft PR - Don't merge this PR automatically label Jun 10, 2020
@ghost ghost dismissed Page-’s stale review June 10, 2020 14:21

Approval reviews not allowed in Draft PRs

@ab77 ab77 closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedss hedss hedss left review comments

@Page- Page- Page- left review comments

Assignees
No one assigned
Labels
versionbot/pr-draft Draft PR - Don't merge this PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wrboyce @Page- @hedss @ab77 @kaisoz