Update request to query by affected ids once they've been resolved #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@balena-ci retest |
Page-
force-pushed
the
update-request-with-affected-ids
branch
3 times, most recently
from
47533b6 to
ba2c1a8
Compare
This avoids the need to use a potentially costly filter twice, once to get the affected ids in advance and then once when running the actual PATCH/DELETE. This also guarantees there can never be an inconsistency between the two Change-type: minor
Page-
force-pushed
the
update-request-with-affected-ids
branch
from
ba2c1a8 to
22285cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the need to use a potentially costly filter twice, once to
get the affected ids in advance and then once when running the actual
PATCH/DELETE. This also guarantees there can never be an inconsistency
between the two
Change-type: minor