Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review getting started guide for Pi 3 #2062

Closed
wants to merge 3 commits into from
Closed

Conversation

chrisys
Copy link
Member

@chrisys chrisys commented Aug 26, 2021

No description provided.

@chrisys chrisys added the versionbot/pr-draft Draft PR - Don't merge this PR automatically label Aug 26, 2021
@chrisys chrisys linked an issue Aug 26, 2021 that may be closed by this pull request
13 tasks
Change-type: patch
Signed-off-by: Chris Crocker-White <[email protected]>
@chrisys chrisys force-pushed the getting-started-review branch from 4a0f4af to 24dd584 Compare August 26, 2021 17:34
Copy link
Member

@vipulgupta2048 vipulgupta2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solid, first draft. Let's talk more about how to handle the ending. Feel there's some improvements we can make there.

Things that we are removing for troubleshooting should definitely go into troubleshooting doc

pages/learn/getting-started.md Outdated Show resolved Hide resolved
pages/learn/getting-started.md Show resolved Hide resolved
pages/learn/getting-started.md Outdated Show resolved Hide resolved
pages/learn/getting-started.md Outdated Show resolved Hide resolved
pages/learn/getting-started.md Show resolved Hide resolved

[balena-node-hello-world]:{{ $links.githubExamples }}/balena-node-hello-world
[github-download-js]:{{ $links.githubExamples }}/balena-node-hello-world/archive/master.zip
[github-download-ts]:{{ $links.githubExamples }}/balena-ts-node-hello-world/archive/main.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we thinking of adding a new language for TS? or just getting rid of it since its a distraction.

shared/getting-started/introduction/_default.md Outdated Show resolved Hide resolved
shared/getting-started/projectSpecific/_default.md Outdated Show resolved Hide resolved
shared/getting-started/projectSpecific/_default.md Outdated Show resolved Hide resolved
@vipulgupta2048 vipulgupta2048 temporarily deployed to resin-docs-preview September 9, 2021 17:52 Inactive
@vipulgupta2048
Copy link
Member

Closing this PR in favor of bite-sized changes that I intend to release for the getting started guide as a whole ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
versionbot/pr-draft Draft PR - Don't merge this PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review getting started guide
4 participants