Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiGeneral: calls: clarify internal IDs #1961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jakogut
Copy link
Contributor

@jakogut jakogut commented Jul 2, 2021

Also add a header above the section detailing usage of internal IDs for
permalinking.

Signed-off-by: Joseph Kogut [email protected]

A user of the API encountered some confusion over usage of internal IDs. Searching yielded the linked issue already describing the problem, and the need to clarify usage of internal IDs. Reading through the docs yielded a page that mostly already clarifies this, but it's part of a larger page on constructing API calls, and can't be linked to on the section for finding and using resource IDs.

Add an H2 header to enable linking, and add a sentence explaining which field for a returned resource is the internal ID.

Related-to: #1881

@jakogut jakogut requested review from 20k-ultra and LucianBuzzo July 2, 2021 16:51
Also add a header above the section detailing usage of internal IDs for
permalinking.

Change-type: patch
Signed-off-by: Joseph Kogut <[email protected]>
@vipulgupta2048 vipulgupta2048 linked an issue Jul 6, 2021 that may be closed by this pull request
@vipulgupta2048
Copy link
Member

Thanks for taking this up @jakogut Maybe an example would help?

I had it in mind where we can show the output of the /v6/device resource, and specifically pointing out the find DEVICE_ID value. Then, mentioning similar instructions for APPLICATION_ID as well. This clearly defined example would help folks out on support.

@jakogut
Copy link
Contributor Author

jakogut commented Jul 6, 2021

we can show the output of the /v6/device resource, and specifically pointing out the find DEVICE_ID value

@vipulgupta2048 This is added starting at line 62. I truncated the output, as the serialized object is quite lengthy, but I could change this to the complete output using select to only retrieve the ID field.

@jakogut
Copy link
Contributor Author

jakogut commented Jul 6, 2021

@balena-ci rebase

@ghost ghost force-pushed the internal-ids branch from da0d657 to ca2a387 Compare July 6, 2021 22:47
@vipulgupta2048
Copy link
Member

@jakogut I would say providing at least some more fields would be nicer

{
a : c,
id : {ldfndlf}
a1 : c,
a2 : c,
a3 : c,
a4 : c,
a5 : c,
...
}

If having a generalised query or process that would help folks in finding their ID's faster then I am all for it. Do put this under a small heading like h3 or h4 as appropriate. So support agents can use that when they are looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify use of <DEVICE ID> in API Documentation
3 participants