Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device start-service and stop-service commands #2689

Merged

Conversation

mlveggo
Copy link
Contributor

@mlveggo mlveggo commented Oct 25, 2023

Resolves: #2690
Change-type: minor


Please check the CONTRIBUTING.md file for relevant information and some
guidance. Keep in mind that the CLI is a cross-platform application that runs
on Windows, macOS and Linux. Tests will be automatically run by balena CI on
all three operating systems, but this will only help if you have added test
code that exercises the modified or added feature code.

Note that each commit message (currently only the first line) will be
automatically copied to the CHANGELOG.md file, so try writing it in a way
that describes the feature or fix for CLI users.

If there isn't a linked issue or if the linked issue doesn't quite match the
PR, please add a PR description to explain its purpose or the features that it
implements. Adding PR comments to blocks of code that aren't self explanatory
usually helps with the review process.

If the PR introduces security considerations or affects the development, build
or release process, please be sure to highlight this in the PR description.

Thank you very much for your contribution!

@maxekman
Copy link

This would be really useful. Thanks @mlveggo!

@otaviojacobi
Copy link
Contributor

Hello @mlveggo and thanks for the contribution. Could you please git commit --amend your commit adding the Change-type footer so CI can run? This will look something like

Add device startservice and stopservice commands

Change-type: minor

Note that there is a blank line between the commit message and the footer. Thanks!

Copy link
Member

@myarmolinsky myarmolinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR and feature addition, happy to have a community contribution! I've left some comments I would apply to both the start and stop service commands. My colleague will review as well when he has a chance

@mlveggo mlveggo force-pushed the add_device_start_stop_service branch from 8222159 to 0169a1a Compare October 29, 2023 08:24
@mlveggo mlveggo changed the title Add device startservice and stopservice commands Add device start-service and stop-service commands Oct 29, 2023
@mlveggo mlveggo force-pushed the add_device_start_stop_service branch from 0169a1a to e01ec44 Compare October 29, 2023 08:32
@mlveggo mlveggo force-pushed the add_device_start_stop_service branch 2 times, most recently from 3c17e95 to e8f5e4a Compare October 31, 2023 18:35
@mlveggo mlveggo force-pushed the add_device_start_stop_service branch from e8f5e4a to 6d21d7c Compare November 1, 2023 07:53
@mlveggo mlveggo force-pushed the add_device_start_stop_service branch 2 times, most recently from 1a2e28a to 500afc7 Compare November 1, 2023 14:10
@mlveggo mlveggo requested a review from otaviojacobi November 1, 2023 14:13
@myarmolinsky
Copy link
Member

Hi, we would like to proceed with merging this PR, could you please rebase it and resolve the merge conflicts when you have a chance? Particularly we have updated our capitanodoc.js to update our docs (unfortunately we did not keep up with this well enough). You should just need to accept all of our changes and re-add your two new commands and re-run build

@mlveggo mlveggo force-pushed the add_device_start_stop_service branch from 500afc7 to f620ab7 Compare November 4, 2023 14:16
@mlveggo mlveggo closed this Nov 4, 2023
@mlveggo mlveggo force-pushed the add_device_start_stop_service branch from f620ab7 to 9bf2671 Compare November 4, 2023 14:20
@mlveggo mlveggo reopened this Nov 4, 2023
@myarmolinsky
Copy link
Member

myarmolinsky commented Nov 6, 2023

Seems an npm dedupe is needed to continue

Edit: To be clear, we will make a dedupe and rebase your PR when it's merged, no action needed on your part

@myarmolinsky myarmolinsky merged commit a434a5e into balena-io:master Nov 6, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add startservice and stopservice commands to device
5 participants