-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device start-service and stop-service commands #2689
Add device start-service and stop-service commands #2689
Conversation
This would be really useful. Thanks @mlveggo! |
Hello @mlveggo and thanks for the contribution. Could you please
Note that there is a blank line between the commit message and the footer. Thanks! |
976cc56
to
e3ce2a3
Compare
e3ce2a3
to
8222159
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR and feature addition, happy to have a community contribution! I've left some comments I would apply to both the start and stop service commands. My colleague will review as well when he has a chance
8222159
to
0169a1a
Compare
0169a1a
to
e01ec44
Compare
3c17e95
to
e8f5e4a
Compare
e8f5e4a
to
6d21d7c
Compare
1a2e28a
to
500afc7
Compare
Hi, we would like to proceed with merging this PR, could you please rebase it and resolve the merge conflicts when you have a chance? Particularly we have updated our capitanodoc.js to update our docs (unfortunately we did not keep up with this well enough). You should just need to accept all of our changes and re-add your two new commands and re-run build |
500afc7
to
f620ab7
Compare
f620ab7
to
9bf2671
Compare
Seems an Edit: To be clear, we will make a dedupe and rebase your PR when it's merged, no action needed on your part |
Change-type: minor
1b47474
to
221c213
Compare
Resolves: #2690
Change-type: minor
Please check the CONTRIBUTING.md file for relevant information and some
guidance. Keep in mind that the CLI is a cross-platform application that runs
on Windows, macOS and Linux. Tests will be automatically run by balena CI on
all three operating systems, but this will only help if you have added test
code that exercises the modified or added feature code.
Note that each commit message (currently only the first line) will be
automatically copied to the CHANGELOG.md file, so try writing it in a way
that describes the feature or fix for CLI users.
If there isn't a linked issue or if the linked issue doesn't quite match the
PR, please add a PR description to explain its purpose or the features that it
implements. Adding PR comments to blocks of code that aren't self explanatory
usually helps with the review process.
If the PR introduces security considerations or affects the development, build
or release process, please be sure to highlight this in the PR description.
Thank you very much for your contribution!