model handel meta attribute #1622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transforming. Previously, only the last join in the joins array got the `serializeCriteria` treatment, ostensibly because the parent join in a many-to-many didn't need it? But this broke down for queries with multiple populates; only the last of the joins would get transformed. Furthermore, when the joins were being generated, they were already using `columnName` in their `select` clauses, so that when `serializeCriteria` ran it could cause issues if there were conflicts between attribute names and column names (see balderdashy/sails#4079). With this patch, only attribute names are used in the `select` clauses for joins, and then _all_ joins are transformed. Note that in the case of many-to-many joins, the first ("parent") join is expected to have `select: false` and no criteria object. It's not clear why this should be (I think `select: []` and `criteria: {}` should work just as well, and tests pass that way), but to avoid unforeseen issues, backwards-compatibility for that has been added in lines 609-612. refs #1499
…ing from .destroy(). (Still needs some love.)
…p the Archived model (which doesn't exist yet)
…me additional notes for future reference.
… the forging from the find query) so that the destroy() query works. Note: At this point, you can take this and use .archive() at the app-level in your own project, provided you hook up your own Archive model. But in subsequent commits, I'll write some code that injects this model automatically, unless configured otherwise.
…hmicky-patch-1
…luislobo-patch-1
[patch] fix annotation mistake
[patch] Fix issue where attribute is required and is a model attribute
…lection with exclusive 2-way association. Also add notes about two things we should really be doing in replaceCollection().
…ompletely null out the other side of a 1..n association, where the singular association happened to be required, but where it still should have worked because there were no matching records (i.e. because the child records had already been cleaned up).
Add more info to error messages when using min/max as column names
Fix usage of `assert.notEqual` in `createEach` test
Include model name in findOne error message
Fix typo: Recursivly -> Recursively
* Fix bug that was occuring in some cases when using .archive() and .archiveOne() with custom column names; including w/ sails-mongo or sails-disk in the new mongo mode * 🦫
- Added the skipEncryption:true to the query.meta of the first forgeStageTwoQuery call and removed it from the second.
Resolved 'UpdateOne: Validation of encrypted attr'
Update url in readme
…tivity check datastore connectivity after registering it
Update node versions in travis.yml
Update async dependency to 2.6.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handel model meta attribute for postgres-adapter. Used for table schemaName.