Skip to content

Commit

Permalink
fix: sync minimum swap fee percentage in ConstantSumPool.sol with Con…
Browse files Browse the repository at this point in the history
…stantProductPool.sol (#117)

* fix: sync minimum swap fee percentage in ConstantSumPool.sol with ConstantProductPool.sol

* fix: correct comment value on _MIN_SWAP_FEE_PERCENTAGE in ConstantProductPool.sol
  • Loading branch information
KingND authored Dec 2, 2024
1 parent 489d9b0 commit b9984fb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/foundry/contracts/pools/ConstantProductPool.sol
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ contract ConstantProductPool is BalancerPoolToken, IBasePool {

uint256 private constant _MIN_INVARIANT_RATIO = 70e16; // 70%
uint256 private constant _MAX_INVARIANT_RATIO = 300e16; // 300%
uint256 private constant _MIN_SWAP_FEE_PERCENTAGE = 1e12; // 0.00001%
uint256 private constant _MIN_SWAP_FEE_PERCENTAGE = 1e12; // 0.0001%
uint256 private constant _MAX_SWAP_FEE_PERCENTAGE = 0.10e18; // 10%

constructor(IVault vault, string memory name, string memory symbol) BalancerPoolToken(vault, name, symbol) {}
Expand Down
2 changes: 1 addition & 1 deletion packages/foundry/contracts/pools/ConstantSumPool.sol
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { IVault } from "@balancer-labs/v3-interfaces/contracts/vault/IVault.sol"
contract ConstantSumPool is IBasePool, BalancerPoolToken {
uint256 private constant _MIN_INVARIANT_RATIO = 70e16; // 70%
uint256 private constant _MAX_INVARIANT_RATIO = 300e16; // 300%
uint256 private constant _MIN_SWAP_FEE_PERCENTAGE = 0.001e18; // 0.001%
uint256 private constant _MIN_SWAP_FEE_PERCENTAGE = 1e12; // 0.0001%
uint256 private constant _MAX_SWAP_FEE_PERCENTAGE = 0.10e18; // 10%

constructor(IVault vault, string memory name, string memory symbol) BalancerPoolToken(vault, name, symbol) {}
Expand Down

0 comments on commit b9984fb

Please sign in to comment.