Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmarks (Refactor ManagedPool constructor arguments) #2086

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Nov 30, 2022

Fix benchmarks in #2078.

Merge into #2078's branch before merging to master.

@jubeira jubeira requested a review from nventuro November 30, 2022 18:11
@nventuro nventuro merged commit 56d9de4 into i-hate-solc-and-everything-with-it Dec 1, 2022
@nventuro nventuro deleted the fix-benchmarks-managed-pool-refactor branch December 1, 2022 15:11
nventuro added a commit that referenced this pull request Dec 1, 2022
* Rename NewPoolParams

* Introduce ConfigParams

* Apply changes to test and helpers

* Fix final tests

* Fix benchmarks. (#2086)

Co-authored-by: Juan Ignacio Ubeira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants