-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sofa-pbrpc cookie #81
base: master
Are you sure you want to change the base?
Conversation
plugin不要放到sample中 用户无法使用 按照之前zuoyan建议 最好增加lite版和full版的rpc库 |
@@ -167,6 +173,20 @@ ReadBufferPtr BinaryRpcRequest::AssembleSucceedResponse( | |||
} | |||
header.data_size = write_buffer.ByteCount() - header_pos - header_size - header.meta_size; | |||
header.message_size = header.meta_size + header.data_size; | |||
|
|||
std::string response_attach_str = cntl->GetResponseAttachBuffer()->ToString(); | |||
size_t attach_size = response_attach_str.size(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
考虑下兼容性
冲突了 |
merge一下吧 |
@@ -103,6 +103,16 @@ bool ReadBuffer::Next(const void** data, int* size) | |||
} | |||
} | |||
|
|||
char* ReadBuffer::CurrentHandle() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个接口是否有必要
} // namespace io | ||
} // namespace sofa | ||
|
||
void sofa_touch_sofa_io_serializer() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
touch函数多余
@qinzuoyan 辛苦左言看下还有问题吗?是否可以merge,多谢哈! |
好,辛苦,我找时间看看 |
这个没问题的话 就合入了? @qinzuoyan @bluebore |
No description provided.