Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sofa-pbrpc cookie #81

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

sofa-pbrpc cookie #81

wants to merge 14 commits into from

Conversation

zd-double
Copy link
Collaborator

No description provided.

@cyshi
Copy link
Collaborator

cyshi commented Mar 28, 2016

plugin不要放到sample中 用户无法使用 按照之前zuoyan建议 最好增加lite版和full版的rpc库

@@ -167,6 +173,20 @@ ReadBufferPtr BinaryRpcRequest::AssembleSucceedResponse(
}
header.data_size = write_buffer.ByteCount() - header_pos - header_size - header.meta_size;
header.message_size = header.meta_size + header.data_size;

std::string response_attach_str = cntl->GetResponseAttachBuffer()->ToString();
size_t attach_size = response_attach_str.size();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑下兼容性

@cyshi
Copy link
Collaborator

cyshi commented Apr 8, 2016

冲突了

@qinzuoyan
Copy link
Collaborator

merge一下吧

@@ -103,6 +103,16 @@ bool ReadBuffer::Next(const void** data, int* size)
}
}

char* ReadBuffer::CurrentHandle()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个接口是否有必要

} // namespace io
} // namespace sofa

void sofa_touch_sofa_io_serializer()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

touch函数多余

@zd-double
Copy link
Collaborator Author

@qinzuoyan 辛苦左言看下还有问题吗?是否可以merge,多谢哈!

@qinzuoyan
Copy link
Collaborator

好,辛苦,我找时间看看

@cyshi
Copy link
Collaborator

cyshi commented Jan 23, 2017

这个没问题的话 就合入了? @qinzuoyan @bluebore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants