Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix float precision bug during offset calculation #785

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Fix float precision bug during offset calculation #785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a68e659
Fix float precision bug during offset calculation
Wisors Aug 25, 2023
3960a1d
Merge pull request #1 from Wisors/Wisors-fix-contentOffset-float-prec…
Wisors Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Chatto/sources/ChatController/BaseChatViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,8 @@ public final class BaseChatViewController: UIViewController {
let diff = lastUsedBounds.height - collectionView.bounds.height
// When collectionView is scrolled to bottom and height increases,
// collectionView adjusts its contentOffset automatically
let isScrolledToBottom = contentSize.height <= collectionView.bounds.maxY - collectionView.contentInset.bottom
let currentBottomPosition = collectionView.bounds.maxY - collectionView.contentInset.bottom
let isScrolledToBottom = contentSize.height - currentBottomPosition <= CGFloat.bma_epsilon
return isScrolledToBottom ? max(0, diff) : diff
}()
self.previousBoundsUsedForInsetsAdjustment = collectionView.bounds
Expand Down
Loading