Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused markdown directives warning #3013

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 12, 2024

Current main:

https://babel.dev/docs/babel-parser

image

This PR:

image

This error is caught by facebook/docusaurus#9394.

@slorber Can docusaurus throw on unused MDX directives? I can't find such an option so if I missed anything please let me know, thank you.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for babel-next ready!

Name Link
🔨 Latest commit 6d580b9
🔍 Latest deploy log https://app.netlify.com/sites/babel-next/deploys/673385d7369a3e0008e3ec83
😎 Deploy Preview https://deploy-preview-3013--babel-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for babel ready!

Name Link
🔨 Latest commit 6d580b9
🔍 Latest deploy log https://app.netlify.com/sites/babel/deploys/673385d7bcf6800008f7d16c
😎 Deploy Preview https://deploy-preview-3013--babel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JLHwung JLHwung merged commit 8fabeac into babel:main Nov 12, 2024
4 checks passed
@JLHwung JLHwung deleted the fix-unused-markdown-directives branch November 12, 2024 19:39
@slorber
Copy link
Contributor

slorber commented Nov 13, 2024

We haven't made it configurable unfortunately.

If you think it would be useful we could add that.

Please open an issue with the motivation so that we don't forget. I think it's reasonable to add siteConfig.markdown.onUnusedDirective: 'throw' or a similar option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants