ci: use output from nbgv instead of env variables #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egil
force-pushed
the
ci-fix-warnings-in-workflows
branch
from
76d3889
to
5bd5bdb
Compare
…getting triggered before check gets a chance to complete
egil
commented
Oct 4, 2024
Comment on lines
+63
to
+93
| // Create the wait task and run the initial check | ||
| // and subscribe to the OnAfterRender event. | ||
| // This must happen before the timer is started, | ||
| // as the check happens inside the renderers synchronization context, | ||
| // and that may be blocked longer than the timeout on overloaded systems, | ||
| // resulting in the timer completing before a single check has | ||
| // has a chance to complete. | ||
| WaitTask = CreateWaitTask(); | ||
| timer = new Timer( | ||
| static (state) => | ||
| { | ||
| var @this = (WaitForHelper<T>)state!; | ||
| @this.logger.LogWaiterTimedOut(@this.renderedFragment.ComponentId); | ||
| @this.checkPassedCompletionSource.TrySetException( | ||
| new WaitForFailedException( | ||
| @this.TimeoutErrorMessage ?? string.Empty, | ||
| @this.checkCount, | ||
| @this.renderedFragment.RenderCount, | ||
| @this.renderer.RenderCount, | ||
| @this.capturedException)); | ||
| }, | ||
| this, | ||
| GetRuntimeTimeout(timeout), | ||
| Timeout.InfiniteTimeSpan); | ||
|
|
||
| InitializeWaiting(); | ||
| CheckAndInitializeWaiting(); | ||
|
|
||
| // If the initial check did not complete successfully, | ||
| // start the timer and recheck after every render until the timer expires. | ||
| if (!WaitTask.IsCompleted) | ||
| { | ||
| timer = new Timer( | ||
| static (state) => | ||
| { | ||
| var @this = (WaitForHelper<T>)state!; | ||
| @this.logger.LogWaiterTimedOut(@this.renderedFragment.ComponentId); | ||
| @this.checkPassedCompletionSource.TrySetException( | ||
| new WaitForFailedException( | ||
| @this.TimeoutErrorMessage ?? string.Empty, | ||
| @this.checkCount, | ||
| @this.renderedFragment.RenderCount, | ||
| @this.renderer.RenderCount, | ||
| @this.capturedException)); | ||
| }, | ||
| this, | ||
| GetRuntimeTimeout(timeout), | ||
| Timeout.InfiniteTimeSpan); | ||
| } |
There was a problem hiding this comment.
@linkdotnet it turns out this order is significant. After the change in the other PR I unskipped a few tests and one of the failed. Its check count was 0. This should ensure that we always perform at one check before the timer is started. It's needed because the checks happens inside the renderes sync context and that may be blocked so the first check never happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
PR meta checklist
mainbranch for codeor targeted at
stablebranch for documentation that is live on bunit.dev.Code PR specific checklist