Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azurerm_data_protection_backup_policy_postgresql_flexible_server #293

Conversation

sschne
Copy link

@sschne sschne commented Oct 25, 2024

Issue-id

PR Checklist


  • I have read the CONTRIBUTING.MD instructions
  • I have changed the resourceDefinition.json
  • I have generated the resource model (there's a models_generated.go file in my PR)
  • I have updated the README.md#resource-status
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Although i'm not sure why the resource needs it's own resource type, other backup vault policies all have it's own resource type, so requesting to add it here. If it's not needed i can also add the resource in the terraform-azurerm-caf module without an azurecaf_name

Does this introduce a breaking change

  • YES
  • NO

Testing

Copy link

Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh added the enhancement New feature or request label Oct 30, 2024
@arnaudlh arnaudlh added this to the 1.2.29 milestone Nov 29, 2024
@arnaudlh arnaudlh merged commit 48bd659 into aztfmod:main Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add support for azurerm_data_protection_backup_policy_postgresql_flexible_server
2 participants