Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to use custom appinsights agent version #1990

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions databricks_access_connectors.tf
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ module "databricks_access_connectors" {
source = "./modules/analytics/databricks_access_connector"
for_each = local.database.databricks_access_connectors

client_config = local.client_config
global_settings = local.global_settings
name = each.value.name
settings = each.value
resource_groups = local.combined_objects_resource_groups
base_tags = local.global_settings.inherit_tags
client_config = local.client_config
global_settings = local.global_settings
name = each.value.name
settings = each.value
resource_groups = local.combined_objects_resource_groups
base_tags = local.global_settings.inherit_tags
remote_objects = {
managed_identities = local.combined_objects_managed_identities
}
Expand Down
40 changes: 20 additions & 20 deletions examples/apim/118-api_management_platform_stv2/configuration.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,20 @@ vnets = {
region = "region1"
vnet = {
name = "example-uks" # prefix-vnet-example-uks
address_space = ["10.0.0.0/16"]
address_space = ["10.0.0.0/16"]
}
subnets = {

# Example subnet for APIM private endpoint

snet_example_apim_uks = {
name = "example-apim-uks" #prefix-snet-example-apim-uks
cidr = ["10.0.1.0/24"]
nsg_key = "nsg_example_apim_uks"
# route_table_key = ""
name = "example-apim-uks" #prefix-snet-example-apim-uks
cidr = ["10.0.1.0/24"]
nsg_key = "nsg_example_apim_uks"
# route_table_key = ""
service_endpoints = ["Microsoft.KeyVault", "Microsoft.Storage", "Microsoft.Sql", "Microsoft.EventHub", "Microsoft.ServiceBus"] # service endpoints required for APIM
}
}
}
}
}

Expand Down Expand Up @@ -142,31 +142,31 @@ public_ip_addresses = {

api_management = {
apim_uks = {
name = "example-uks" # prefix-apim-example-uks
resource_group_key = "rg_example_apim_uks"
publisher_name = "apim.example.sre.com"
publisher_email = "[email protected]"
sku_name = "Developer_1" # https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/api_management#sku_name
region = "region1"
name = "example-uks" # prefix-apim-example-uks
resource_group_key = "rg_example_apim_uks"
publisher_name = "apim.example.sre.com"
publisher_email = "[email protected]"
sku_name = "Developer_1" # https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/api_management#sku_name
region = "region1"

# Required to deploy APIM on platform verions stv2.*
public_ip_address = {
key = "pip_apim_uks"
# lz_key = ""
}
public_ip_address = {
key = "pip_apim_uks"
# lz_key = ""
}

virtual_network_type = "Internal" # The type of virtual network you want to use, valid values include: None, External, Internal. Defaults to None.
virtual_network_configuration = {
vnet_key = "vnet_example_uks"
subnet_key = "snet_example_apim_uks"
# lz_key = ""
# lz_key = ""
}

identity = {
type = "UserAssigned"
managed_identity_keys = ["msi_apim_uks"]
}

portal = {
host_name = "example.apim.com"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ aks_clusters = {

addon_profile = {
oms_agent = {
log_analytics_key = "central_logs_region1"
log_analytics_key = "central_logs_region1"
msi_auth_for_monitoring_enabled = true
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,23 +63,23 @@ virtual_machines = {
disable_password_authentication = true

custom_data = {
templatefile = "compute/virtual_machine/113-single-linux-custom-data-template/custom_data.tpl"
my_value = "my_value"
templatefile = "compute/virtual_machine/113-single-linux-custom-data-template/custom_data.tpl"
my_value = "my_value"
}
dynamic_custom_data = {
vnets = {
vnet_region1 ={}
vnet_region1 = {}
}
storage_accounts = {
sa1 = {
file_share = "share1"
file_share_directory = "dir1"
file_share = "share1"
file_share_directory = "dir1"
}
}
keyvault_keys = {
key1 = {
keyvault_key = "example_vm_rg1"
name = "disk-key"
name = "disk-key"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ resource_groups = {

databricks_access_connectors = {
dac_1 = {
name = "example-name"
resource_group_key = "dac_test"
identity = {
type = "UserAssigned" #SystemAssigned
managed_identity_keys = ["dac_test"]
name = "example-name"
resource_group_key = "dac_test"
identity = {
type = "UserAssigned" #SystemAssigned
managed_identity_keys = ["dac_test"]
}
tags = {
test = "test"
test1 = "test1"
}
tags = {
test = "test"
test1 = "test1"
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ virtual_machines = {
priority = "Spot"
eviction_policy = "Deallocate"

patch_mode = "AutomaticByPlatform"
patch_mode = "AutomaticByPlatform"
bypass_platform_safety_checks_on_user_schedule_enabled = true
# When you want to load the file from the folder in the custom_data always use the relative path from the caf_solution in landing zones
custom_data = "../../examples/compute/virtual_machine/101-single-windows-vm/scripts/custom.ps1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ global_settings = {
}

inherit_tags = true

resource_defaults = {
virtual_machines = {
# set the below to enable az managed boot diagostics for vms
Expand Down Expand Up @@ -70,17 +70,17 @@ virtual_machines = {
# Spot VM to save money
priority = "Spot"
eviction_policy = "Deallocate"
patch_mode = "AutomaticByPlatform"

patch_mode = "AutomaticByPlatform"
bypass_platform_safety_checks_on_user_schedule_enabled = true

# Value of the nic keys to attach the VM. The first one in the list is the default nic
network_interface_keys = ["nic0"]

os_disk = {
name = "example_vm1-os"
caching = "ReadWrite"
storage_account_type = "Standard_LRS"
name = "example_vm1-os"
caching = "ReadWrite"
storage_account_type = "Standard_LRS"
}
identity = {
type = "SystemAssigned" #SystemAssigned OR UserAssigned OR SystemAssigned, UserAssigned
Expand All @@ -105,10 +105,10 @@ virtual_machines = {
name = "server1-data1"
storage_account_type = "Standard_LRS"
# Only Empty is supported. More community contributions required to cover other scenarios
create_option = "Empty"
disk_size_gb = "10"
lun = 1
zones = ["1"]
create_option = "Empty"
disk_size_gb = "10"
lun = 1
zones = ["1"]
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion examples/mssql_mi/200-mi/configuration.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ vnets = {
resource_group_key = "networking_region1"
vnet = {
name = "sqlmi-rg1"
address_space = ["172.25.88.0/21","10.2.0.0/24"]
address_space = ["172.25.88.0/21", "10.2.0.0/24"]
}
subnets = {
sqlmi1 = {
Expand Down
2 changes: 1 addition & 1 deletion examples/mssql_mi/200-mi/nsg.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,6 @@ network_security_group_definition = {
]
}
subnet02 = {
nsg= []
nsg = []
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ recovery_vaults = {
backup_policies = {
vm_workloads = {
sql = {
name = "SQLTest"
workload_type = "SQLDataBase"
vault_key = "asr1"
rg_key = "primary"
timezone = "UTC"
name = "SQLTest"
workload_type = "SQLDataBase"
vault_key = "asr1"
rg_key = "primary"
timezone = "UTC"
compression_enabled = false
protection_policies = {
sqlfull = {
Expand All @@ -23,8 +23,8 @@ recovery_vaults = {
frequency = "Daily"
time = "15:00"
}
retention_daily = {
count = 8
retention_daily = {
count = 8
}
}
sqllog = {
Expand All @@ -39,11 +39,11 @@ recovery_vaults = {
}
}
saphana = {
name = "SAPHANATest"
workload_type = "SAPHanaDatabase"
vault_key = "asr1"
rg_key = "primary"
timezone = "UTC"
name = "SAPHANATest"
workload_type = "SAPHanaDatabase"
vault_key = "asr1"
rg_key = "primary"
timezone = "UTC"
compression_enabled = false
protection_policies = {
saphanafull = {
Expand All @@ -52,8 +52,8 @@ recovery_vaults = {
frequency = "Daily"
time = "15:00"
}
retention_daily = {
count = 8
retention_daily = {
count = 8
}
}
saphanalog = {
Expand All @@ -65,7 +65,7 @@ recovery_vaults = {
count = 8
}
}
}
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@ cognitive_services_account = {
resource_group = {
key = "rg1"
}
name = "pinecone-llm-demoopenai"
kind = "OpenAI"
sku_name = "S0"
name = "pinecone-llm-demoopenai"
kind = "OpenAI"
sku_name = "S0"
custom_subdomain_name = "cs-alz-caf-llm-demoopenai"
}
}

managed_identities = {
workload-msi = {
name = "example-msi-openai-rolemap-msi"
name = "example-msi-openai-rolemap-msi"
resource_group_key = "rg1"
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ vnets = {
}
subnets = {
default = {
name = "default"
cidr = ["10.5.1.0/24"]
name = "default"
cidr = ["10.5.1.0/24"]
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ search_services = {
identity = {
type = "SystemAssigned"
}
local_authentication_enabled = false
local_authentication_enabled = false
# public_network_access_enabled = true
# allowed_ips = ["13.478.57.73"]
}
Expand Down
2 changes: 1 addition & 1 deletion examples/tests/mock/e2e_plan.tftest.hcl
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ mock_provider "azurerm" {
}

mock_provider "azurerm" {
alias = "vhub"
alias = "vhub"
source = "./tests/mock_data"
}

Expand Down
2 changes: 1 addition & 1 deletion examples/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -1130,7 +1130,7 @@ variable "maintenance_assignment_virtual_machine" {
default = {}
}
variable "search_services" {
default = {}
default = {}
}
variable "load_test" {
default = {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,19 @@ app_services = {

ip_restriction = [
{
name = "deny-all-traffic"
action = "Deny"
ip_address = "0.0.0.0/0"
priority = 65000
name = "deny-all-traffic"
action = "Deny"
ip_address = "0.0.0.0/0"
priority = 65000
}
]

scm_ip_restriction = [
{
name = "allow-all-traffic"
action = "Allow"
ip_address = "0.0.0.0/0"
priority = 65000
name = "allow-all-traffic"
action = "Allow"
ip_address = "0.0.0.0/0"
priority = 65000
}
]
}
Expand Down
4 changes: 2 additions & 2 deletions modules/analytics/databricks_access_connector/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ locals {
try(var.settings.tags, null)
) : try(var.settings.tags, null)

resource_group = var.resource_groups[try(var.settings.lz_key, var.settings.resource_group.lz_key, var.client_config.landingzone_key)][try(var.settings.resource_group.key, var.settings.resource_group_key)]

resource_group = var.resource_groups[try(var.settings.lz_key, var.settings.resource_group.lz_key, var.client_config.landingzone_key)][try(var.settings.resource_group.key, var.settings.resource_group_key)]
}

terraform {
Expand Down
2 changes: 1 addition & 1 deletion modules/analytics/databricks_access_connector/module.tf
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ resource "azurerm_databricks_access_connector" "databricks_access_connector" {
identity_ids = concat(local.managed_identities, try(identity.value.identity_ids, []))
}
}

}
Loading
Loading