Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduces code duplication #445

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

refactor: reduces code duplication #445

wants to merge 8 commits into from
+667 −1,051

Conversation

hugop95
Copy link
Contributor

@hugop95 hugop95 commented Jan 19, 2025 •
edited
Loading

Description

This PR focuses on reducing code duplication:

  • Creates a CommonOptions interface (includes type, locales, specialCharacters, ignoreCase, alphabet).
    • Does not contain type yet, as some rules handle the unsorted type while others don't.
  • Creates a commonJsonSchema variable regrouping common JSON schemas to all rules.
  • Creates a PartitionByCommentOption interface.
  • Creates a GroupsOptions interface.
  • Creates a reportErrors function.

No test impacted.

What is the purpose of this pull request?

  • Other

@hugop95 hugop95 marked this pull request as ready for review January 19, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hugop95