Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sort-maps): adds groups, customGroups and newlinesBetween #443

Merged
merged 4 commits into from
Jan 18, 2025

Conversation

hugop95
Copy link
Contributor

@hugop95 hugop95 commented Jan 12, 2025

As usual, most lines added are tests and documentation 🙂

Description

This PR adds the following features to sort-maps, to look very similar to sort-array-includes:

  • groups option (no predefined group).
  • newlinesBetween option.
  • Array-based customGroups.
  • useConfigurationIf.allNamesMatchPattern.

What is the purpose of this pull request?

  • New Feature

@hugop95 hugop95 force-pushed the feat/sort-maps/groups branch 6 times, most recently from 1438df5 to c515aa0 Compare January 18, 2025 00:08
@hugop95 hugop95 force-pushed the feat/sort-maps/groups branch from c515aa0 to 797057b Compare January 18, 2025 00:09
@hugop95 hugop95 marked this pull request as ready for review January 18, 2025 00:09
@azat-io
Copy link
Owner

azat-io commented Jan 18, 2025

Nice, thank you!

@azat-io azat-io merged commit 317baaa into azat-io:main Jan 18, 2025
8 checks passed
@hugop95 hugop95 deleted the feat/sort-maps/groups branch January 18, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants