Several improvements: Support move semantic + remove vector in favour of std one + add support for STL string #245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements in this PR:
1) using std::vector instead of current vector class
2)Support for move semantic for strings to avoid a buffer copy for rvalues
Move semantic allows to avoid a second buffer copy when calling ESP-DASH with rvalues like that:
The created buffer will directly be transferred to the internal class, which reduces heap fragmentation.
These
update()
calls being frequently called so this is a relevant optimizaiton.2) Add support for STL std::string in ESP-DASH with
-D DASH_USE_STL_STRING=1