-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WiP] #634 Logging #660
base: main
Are you sure you want to change the base?
[WiP] #634 Logging #660
Conversation
Work in Progress |
@mhmdkrmabd @HadesArchitect how we doing on this? Do we want to pull this into the next major release (right click)? |
It looks good and will be finalized tomorrow, but I'm worried about proper testing. With no autotests and a huge changeset, we'll need to test everything manually. |
|
With more debug added, I see why the app is never It brings two questions:
@mhmdkrmabd @digiserg, wdyt?
Much later, after I manually exit the workbench: ...
19:25:57.638 › PTY instance exited! exitcode: 0 signal: 9 Some log output is omitted for clarity |
Manual call for aleks@aleksmacbookcable axonops-workbench % ./main/bin/cqlsh/cqlsh
[3428] Failed to load Python shared library '/Users/aleks/axonops-workbench/main/bin/cqlsh/_internal/Python': dlopen: dlopen(/Users/aleks/axonops-workbench/main/bin/cqlsh/_internal/Python, 0x000A): tried: '/Users/aleks/axonops-workbench/main/bin/cqlsh/_internal/Python' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/aleks/axonops-workbench/main/bin/cqlsh/_internal/Python' (no such file), '/Users/aleks/axonops-workbench/main/bin/cqlsh/_internal/Python' (no such file)
aleks@aleksmacbookcable axonops-workbench % echo $?
255 The cqlsh file was downloaded as described in instructions |
@HadesArchitect well based on the log it seems the building process of cqlsh wasn't successful, a Python shared library is missing, and the workbench - and this is only happening on macOS - is running an initialization process to grant privileges regarding the access of OS keychain and other permissions. The workbench would show notification to users about missing binaries, but in our case it's seems to be corrupted. Did you build the binaries from your side? If so you please try those instead: P.S: Saw the new comment. Let us test the darwin version of the binaries in our side to make sure it's not a common issue |
Thanks @mhmdkrmabd I'll try those tomorrow |
Use this script to download the binaries: CQLSH_BUILD_VERSION="0.14.3"
CQLSH_GITHUB_URL='https://github.com/axonops/axonops-workbench-cqlsh/releases/download'
mkdir -p main/bin
for binary in cqlsh keys_generator; do
curl -fL ${CQLSH_GITHUB_URL}/${CQLSH_BUILD_VERSION}/${binary}-$(uname -s)-$(uname -m).tar | tar xf - -C main/bin
mv main/bin/${binary}-$(uname -s)-$(uname -m) main/bin/${binary}
mv main/bin/${binary}/${binary}-$(uname -s)-$(uname -m) main/bin/${binary}/${binary}
done |
Thanks, @digiserg. This script works. I see it brings more than just two files; I'll update the documentation accordingly. The first question is answered, the second one is still to do: "How do we detect an issue like that so we write something meaningful to user and in log?" I'd extend check of these dependencies: not only check the presence of the files, but maybe call them and check exit code. |
Fixes #634