Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data tables for Unicode 16 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wezm
Copy link

@wezm wezm commented Oct 9, 2024

I took a stab at updating things for Unicode 16. I've updated the data and now there are failing tests:

---- test_lb_default stdout ----
thread 'test_lb_default' panicked at tests/test_default.rs:57:9:
assertion `left == right` failed: String: ‘⏩ »’, comment:  × [0.3] BLACK RIGHT-POINTING DOUBLE TRIANGLE (AL) × [7.01] SPACE (SP_NotEastAsian) × [15.21] RIGHT-POINTING DOUBLE ANGLE QUOTATION MARK (QU_QU_Pf_QUmPi_NotEastAsian) ÷ [0.3]
  left: [4, 6]
 right: [6]

I'm a bit lost in the rules2table DSL, which I think needs updating. It also seems like there may have been some changes in Unicode 15 that were not applied in the previous update. E.g. LB15 was replaced with LB15a and LB15b. Now there's also LB15c and LB15d. I'm unsure how to translate these into the DSL. I figured opening a PR with the data update may be helpful as a starting point for an Unicode 16 update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant