Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: starknet GMP #731

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

ctoyan
Copy link
Contributor

@ctoyan ctoyan commented Dec 18, 2024

Description

This PR consists of:

  • call contract event verification
  • signer rotation event verification
  • starknet specific types and events de/serialisation implementations

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

You would need the Starknet relayer, in order to manually test, which is not open sourced or deployed yet.
Also we don't have integration or end-to-end tests yet.

Expected Behaviour

Handle GMP messages from other amplifier chains

Other Notes

The FieldElementAndEventIndex PR must be merged to main before this PR manages to compile successfully.

@ctoyan ctoyan requested a review from a team as a code owner December 18, 2024 15:28
@ctoyan ctoyan marked this pull request as draft December 27, 2024 11:25
@ctoyan
Copy link
Contributor Author

ctoyan commented Dec 27, 2024

Converted it back to draft, as I expect some changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant