Add a method to report library version from ApiHandle #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
force-pushed
the
sr/reportVersion
branch
from
3ae76d4 to
18c5c03
Compare
graebm
reviewed
Dec 7, 2023
include/aws/crt/Api.h
Outdated
| * Gets the version of the AWS-CRT-CPP library | ||
| * @return- CrtCppVersion representing the library version | ||
| */ | ||
| const CrtCppVersion &GetCrtVersion() const; |
There was a problem hiding this comment.
trivial: simpler/safer to just return by value const CrtCppVersion -> CrtCppVersion
There was a problem hiding this comment.
trivial: GetCrtVersion() -> GetVersion()
There was a problem hiding this comment.
I thought about simple "GetVersion" but then remembered there is one OS manufacturer that defines GetVersion to a macro in their SDK headers :-).
SergeyRyabinin
force-pushed
the
sr/reportVersion
branch
3 times, most recently
from
9399a44 to
b0ed502
Compare
SergeyRyabinin
force-pushed
the
sr/reportVersion
branch
from
b0ed502 to
319b262
Compare
sbiscigl
approved these changes
Dec 7, 2023
graebm
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
CRT-CPP package does not expose it's version.
Description of changes:
Add a method that will return the version declared at the build time.
update: update clang format
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.